Skip to content

Commit c70be24

Browse files
authored
ci: add marimo tests back (#1286)
1 parent abe511c commit c70be24

File tree

1 file changed

+19
-12
lines changed

1 file changed

+19
-12
lines changed

.github/workflows/downstream_tests.yml

+19-12
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,7 @@ jobs:
5555
matrix:
5656
python-version: ["3.12"]
5757
os: [ubuntu-latest]
58-
# temporarily commented out due to flaky tests
59-
# dependencies: ["core", "core,optional"]
60-
dependencies: ["core"]
58+
dependencies: ["core,optional"]
6159

6260
runs-on: ${{ matrix.os }}
6361
steps:
@@ -75,19 +73,27 @@ jobs:
7573
run: |
7674
git clone https://github.com/marimo-team/marimo.git --depth=1
7775
cd marimo
76+
uv venv -p 3.12
7877
git log
7978
- name: install-basics
8079
run: uv pip install --upgrade tox virtualenv setuptools hatch --system
8180
- name: install-marimo-dev
8281
run: |
8382
cd marimo
84-
uv pip install -e ".[dev]" --system
83+
. .venv/bin/activate
84+
uv pip install -e ".[dev]"
85+
which python
8586
- name: install-narwhals-dev
8687
run: |
87-
uv pip uninstall narwhals --system
88-
uv pip install -e . --system
88+
cd marimo
89+
. .venv/bin/activate
90+
uv pip uninstall narwhals
91+
uv pip install -e ./..
8992
- name: show-deps
90-
run: uv pip freeze
93+
run: |
94+
cd marimo
95+
. .venv/bin/activate
96+
uv pip freeze
9197
- name: Create assets directory, copy over index.html
9298
continue-on-error: true
9399
run: |
@@ -98,12 +104,13 @@ jobs:
98104
if: ${{ matrix.dependencies == 'core,optional' }}
99105
run: |
100106
cd marimo
101-
hatch run +py=${{ matrix.python-version }} test-optional:test-narwhals
107+
. .venv/bin/activate
108+
# make sure that we use the .venv when running tests, so that
109+
# the local narwhals install is picked up
110+
sed -i '/^\[tool.hatch.envs.default\]/a path = ".venv"' pyproject.toml
111+
hatch run python -c "import narwhals; print(narwhals.__file__)"
112+
hatch run test-optional:test-narwhals
102113
timeout-minutes: 15
103-
- name: Run typechecks
104-
run: |
105-
cd marimo
106-
hatch run typecheck:check
107114

108115
scikit-lego:
109116
strategy:

0 commit comments

Comments
 (0)