Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make generated C++ comply with -Wdouble-promotion #621

Open
bocchino opened this issue Feb 19, 2025 · 0 comments · May be fixed by #624
Open

Make generated C++ comply with -Wdouble-promotion #621

bocchino opened this issue Feb 19, 2025 · 0 comments · May be fixed by #624
Assignees
@bocchino
Labels
code generation Issues related to code generation code quality Issues related to code quality

Comments

@bocchino
Copy link
Collaborator

See this comment in the F Prime repo:

https://github.com/nasa/fprime/blob/34a4e2c96d4f6153a0f2cc666aa9621ea7b3d61d/CMakeLists.txt#L28

Complying with this warning shouldn't be hard. It looks like the warning is tripped when the code passes an F32 value to the format function, which implicitly promotes it to a double.
@bocchino bocchino added code generation Issues related to code generation code quality Issues related to code quality labels Feb 19, 2025
@bocchino bocchino self-assigned this Feb 19, 2025
@bocchino bocchino moved this from To do to In progress in FPP Fixes and Enhancements Feb 19, 2025
@bocchino bocchino linked a pull request Feb 20, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bocchino bocchino

Labels
code generation Issues related to code generation code quality Issues related to code quality
Projects
FPP Fixes and Enhancements
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve quality of generated C++ nasa/fpp
1 participant
@bocchino