Merge pull request #341 from edusperoni/fix/null-label-on-tabs

farfromrefug · web-flow · commit aec17844d81a · 2021-11-08T19:42:42.000+01:00
fix(tabs): prevent crash when TabStripItem isn't loaded yet
diff --git a/src/tabs/tabs.android.ts b/src/tabs/tabs.android.ts
@@ -693,7 +693,7 @@ export class Tabs extends TabsBase {
         const tabItems = new Array<com.nativescript.material.core.TabItemSpec>();
         items.forEach((tabStripItem: TabStripItem, i, arr) => {
             if (!this._unSelectedItemColor) {
-                this._unSelectedItemColor = tabStripItem.label.style.color;
+                this._unSelectedItemColor = tabStripItem.label?.style.color;
             }
             tabStripItem._index = i;
             const tabItemSpec = this.createTabItemSpec(tabStripItem);

Original file line number	Diff line number	Diff line change
`@@ -693,7 +693,7 @@ export class Tabs extends TabsBase {`
`693`	`693`	`const tabItems = new Array<com.nativescript.material.core.TabItemSpec>();`
`694`	`694`	`items.forEach((tabStripItem: TabStripItem, i, arr) => {`
`695`	`695`	`if (!this._unSelectedItemColor) {`
`696`		`- this._unSelectedItemColor = tabStripItem.label.style.color;`
	`696`	`+ this._unSelectedItemColor = tabStripItem.label?.style.color;`
`697`	`697`	`}`
`698`	`698`	`tabStripItem._index = i;`
`699`	`699`	`const tabItemSpec = this.createTabItemSpec(tabStripItem);`