Testing (#4)

transistive · web-flow · commit 85c55c3f9160 · 2020-12-11T00:08:02.000+01:00
* moved prepary body method to HttpCypherFormatter

* ran php-cs-fixer

* added complex query tests

* fixed version 3.5 api

* updated jenkinsfile to recreate the database during testing

* added typehint for discovery result

* further refinement of the docker files
diff --git a/Jenkinsfile b/Jenkinsfile
@@ -22,12 +22,32 @@ pipeline {
         }
         stage('Test') {
             steps {
+                sh 'docker-compose -f docker/docker-compose-4.2.yml down --volumes'
+                sh 'docker-compose -f docker/docker-compose-4.2.yml up -d --force-recreate'
                 sh 'docker-compose -f docker/docker-compose-4.2.yml run client php vendor/bin/phpunit'
+                sh 'docker-compose -f docker/docker-compose-4.2.yml down'
+
+
+                sh 'docker-compose -f docker/docker-compose-4.1.yml down --volumes'
+                sh 'docker-compose -f docker/docker-compose-4.1.yml up -d --force-recreate'
                 sh 'docker-compose -f docker/docker-compose-4.1.yml run client php vendor/bin/phpunit'
+                sh 'docker-compose -f docker/docker-compose-4.1.yml down'
+
+
+                sh 'docker-compose -f docker/docker-compose-4.0.yml down --volumes'
+                sh 'docker-compose -f docker/docker-compose-4.0.yml up -d --force-recreate'
                 sh 'docker-compose -f docker/docker-compose-4.0.yml run client php vendor/bin/phpunit'
+                sh 'docker-compose -f docker/docker-compose-4.0.yml down'
+
+
+                sh 'docker-compose -f docker/docker-compose-3.5.yml down --volumes'
+                sh 'docker-compose -f docker/docker-compose-3.5.yml up -d --force-recreate'
                 sh 'docker-compose -f docker/docker-compose-3.5.yml run client php vendor/bin/phpunit'
-                sh 'docker-compose -f docker/docker-compose-2.3.yml run client php vendor/bin/phpunit'
+                sh 'docker-compose -f docker/docker-compose-3.5.yml down'
+
+//                 sh 'docker-compose -f docker/docker-compose-2.3.yml run client php vendor/bin/phpunit'
                 sh 'docker-compose -f docker/docker-compose-php-7.4.yml run client php vendor/bin/phpunit'
+                sh 'docker-compose -f docker/docker-compose-php-7.4.yml down'
             }
         }
     }
diff --git a/docker/Dockerfile-php-8.0 b/docker/Dockerfile-php-8.0
@@ -14,7 +14,7 @@ RUN apt-get update && apt-get install -y \
 ARG WITH_XDEBUG=false
 
 RUN if [ $WITH_XDEBUG = "true" ] ; then \
-        pecl install xdebug-3; \
+        pecl install xdebug; \
         docker-php-ext-enable xdebug; \
 fi;
 
diff --git a/docker/docker-compose-2.3.yml b/docker/docker-compose-2.3.yml
@@ -9,10 +9,14 @@ services:
         build:
             context: ../
             dockerfile: docker/Dockerfile-php-8.0
+            args:
+                - WITH_XDEBUG=true
         networks:
             - neo4j
         depends_on:
             - neo4j
+        volumes:
+            - ../:/opt/project
     neo4j:
         networks:
             - neo4j
diff --git a/docker/docker-compose-3.5.yml b/docker/docker-compose-3.5.yml
@@ -9,10 +9,14 @@ services:
         build:
             context: ../
             dockerfile: docker/Dockerfile-php-8.0
+            args:
+                - WITH_XDEBUG=true
         networks:
             - neo4j
         depends_on:
-            -   neo4j
+            - neo4j
+        volumes:
+            - ../:/opt/project
     neo4j:
         networks:
             - neo4j
diff --git a/docker/docker-compose-4.0.yml b/docker/docker-compose-4.0.yml
@@ -9,10 +9,14 @@ services:
         build:
             context: ../
             dockerfile: docker/Dockerfile-php-8.0
+            args:
+                - WITH_XDEBUG=true
         networks:
             - neo4j
         depends_on:
-            -   neo4j
+            - neo4j
+        volumes:
+            - ../:/opt/project
     neo4j:
         networks:
             - neo4j
diff --git a/docker/docker-compose-4.1.yml b/docker/docker-compose-4.1.yml
@@ -9,10 +9,14 @@ services:
         build:
             context: ../
             dockerfile: docker/Dockerfile-php-8.0
+            args:
+                - WITH_XDEBUG=true
         networks:
             - neo4j
         depends_on:
-            -   neo4j
+            - neo4j
+        volumes:
+            - ../:/opt/project
     neo4j:
         networks:
             - neo4j
diff --git a/docker/docker-compose-4.2.yml b/docker/docker-compose-4.2.yml
@@ -9,10 +9,14 @@ services:
         build:
             context: ../
             dockerfile: docker/Dockerfile-php-8.0
+            args:
+                - WITH_XDEBUG=true
         networks:
             - neo4j
         depends_on:
-            -   neo4j
+            - neo4j
+        volumes:
+            - ../:/opt/project
     neo4j:
         networks:
             - neo4j
diff --git a/docker/docker-compose-php-7.4.yml b/docker/docker-compose-php-7.4.yml
@@ -9,10 +9,14 @@ services:
         build:
             context: ../
             dockerfile: docker/Dockerfile-php-7.4
+            args:
+                - WITH_XDEBUG=true
         networks:
             - neo4j
         depends_on:
-            -   neo4j
+            - neo4j
+        volumes:
+            - ../:/opt/project
     neo4j:
         networks:
             - neo4j
diff --git a/phpunit-bootstrap.php b/phpunit-bootstrap.php
@@ -12,7 +12,6 @@
  */
 
 use Laudis\Neo4j\ClientBuilder;
-use Laudis\Neo4j\Exception\Neo4jException;
 
 include __DIR__.'/vendor/autoload.php';
 
@@ -27,6 +26,7 @@
 
         return;
     } catch (Throwable $e) {
+        error_log($e->getMessage()."\n");
         --$retriesLeft;
         sleep(5);
     }
diff --git a/src/ClientBuilder.php b/src/ClientBuilder.php
@@ -18,6 +18,8 @@
 use InvalidArgumentException;
 use Laudis\Neo4j\Contracts\ClientInterface;
 use Laudis\Neo4j\Contracts\DriverInterface;
+use Laudis\Neo4j\Formatter\HttpCypherFormatter;
+use Laudis\Neo4j\HttpDriver\RequestFactory;
 use Laudis\Neo4j\Network\Bolt\BoltDriver;
 use Laudis\Neo4j\Network\Bolt\BoltInjections;
 use Laudis\Neo4j\Network\Http\HttpDriver;
@@ -64,7 +66,10 @@ public function addHttpConnection(string $alias, string $url, HttpInjections $in
         if (!isset($parse['host'], $parse['user'], $parse['pass'])) {
             throw new InvalidArgumentException('The provided url must have a parsed host, user and pass value');
         }
-        $conneciton = new HttpDriver($parse, new VersionDiscovery(), $injections ?? new HttpInjections());
+        $injections = $injections ?? new HttpInjections();
+        $factory = $injections->requestFactory();
+        $requestFactory = new RequestFactory($factory, $injections->streamFactory(), new HttpCypherFormatter());
+        $conneciton = new HttpDriver($parse, new VersionDiscovery($requestFactory, $injections->client()), $injections);
         $this->connectionPool->put($alias, $conneciton);
 
         return $this;
diff --git a/src/HttpDriver/RequestFactory.php b/src/HttpDriver/RequestFactory.php
@@ -40,7 +40,7 @@ public function openTransaction(RequestData $data): RequestInterface
         return $this->createRequest($data, 'POST');
     }
 
-    private function createRequest(RequestData $data, string $method, string $body = ''): RequestInterface
+    public function createRequest(RequestData $data, string $method, string $body = ''): RequestInterface
     {
         $combo = base64_encode($data->getUser().':'.$data->getPassword());
 
diff --git a/src/Network/Http/HttpDriver.php b/src/Network/Http/HttpDriver.php
@@ -59,19 +59,22 @@ public function aquireSession(): SessionInterface
             $this->parsedUrl['port'] ?? self::DEFAULT_PORT,
             $this->parsedUrl['path'] ?? ''
         );
-        $tsx = $this->decorator->discoverTransactionUrl($url, $this->injections);
+
+        $requestData = new RequestData(
+            $url,
+            $this->parsedUrl['user'],
+            $this->parsedUrl['pass'],
+            false
+        );
+        $tsx = $this->decorator->discoverTransactionUrl($requestData, $this->injections->database());
+        $requestData = $requestData->withEndpoint($tsx);
 
         $formatter = new HttpCypherFormatter();
         $this->session = new HttpSession(
             new RequestFactory($this->injections->requestFactory(), $this->injections->streamFactory(), $formatter),
             $this->injections->client(),
             $formatter,
-            new RequestData(
-                $tsx,
-                $this->parsedUrl['user'],
-                $this->parsedUrl['pass'],
-                false
-            )
+            $requestData
         );
 
         return $this->session;
diff --git a/src/Network/VersionDiscovery.php b/src/Network/VersionDiscovery.php
@@ -14,18 +14,19 @@
 namespace Laudis\Neo4j\Network;
 
 use JsonException;
-use Laudis\Neo4j\Network\Http\HttpInjections;
+use Laudis\Neo4j\Databags\RequestData;
+use Laudis\Neo4j\HttpDriver\RequestFactory;
 use Psr\Http\Client\ClientExceptionInterface;
 use Psr\Http\Client\ClientInterface;
-use Psr\Http\Message\RequestFactoryInterface;
 
 /**
  * @psalm-type DiscoveryResult = array{
  *      bolt_routing:string,
  *      transaction: string,
  *      bolt_direct: string,
  *      neo4j_version: string,
- *      neo4j_edition: string
+ *      neo4j_edition: string,
+ *      data?: string
  * }
  * @psalm-type DiscoveryResultLegacy = array{
  *     extensions: array,
@@ -46,21 +47,30 @@
  */
 final class VersionDiscovery
 {
+    private RequestFactory $requestFactory;
+    private ClientInterface $client;
+
+    public function __construct(RequestFactory $requestFactory, ClientInterface $client)
+    {
+        $this->requestFactory = $requestFactory;
+        $this->client = $client;
+    }
+
     /**
      * @throws ClientExceptionInterface
      * @throws JsonException
      */
-    public function discoverTransactionUrl(string $url, HttpInjections $injections): string
+    public function discoverTransactionUrl(RequestData $data, string $database): string
     {
-        $discovery = $this->discovery($injections->client(), $injections->requestFactory(), $url);
+        $discovery = $this->discovery($data);
         $version = $discovery['neo4j_version'] ?? null;
 
         if ($version === null) {
-            $discovery = $this->discovery($injections->client(), $injections->requestFactory(), $url.'/db/data');
+            $discovery = $this->discovery($data->withEndpoint($discovery['data'] ?? $data->getEndpoint().'/db/data'));
         }
         $tsx = $discovery['transaction'];
 
-        return str_replace('{databaseName}', $injections->database(), $tsx);
+        return str_replace('{databaseName}', $database, $tsx);
     }
 
     /**
@@ -69,9 +79,9 @@ public function discoverTransactionUrl(string $url, HttpInjections $injections):
      *
      * @return DiscoveryResult|DiscoveryResultLegacy $discovery
      */
-    private function discovery(ClientInterface $client, RequestFactoryInterface $factory, string $uri): array
+    private function discovery(RequestData $data): array
     {
-        $response = $client->sendRequest($factory->createRequest('GET', $uri));
+        $response = $this->client->sendRequest($this->requestFactory->createRequest($data, 'GET'));
 
         /** @var DiscoveryResultLegacy|DiscoveryResult $result */
         $result = json_decode($response->getBody()->getContents(), true, 512, JSON_THROW_ON_ERROR);
