-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate Block#playerWillDestroy result to Block#playerDestroy #1034
Propagate Block#playerWillDestroy result to Block#playerDestroy #1034
Conversation
Fixes Decorative Pots dropping themselves instead of Bricks/Sherds when broken with tools like Swords.
Last commit published: f844e9c9c35360746a34a7e764659647e60c6810. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1034' // https://github.com/neoforged/NeoForge/pull/1034
url 'https://prmaven.neoforged.net/NeoForge/pr1034'
content {
includeModule('net.neoforged', 'testframework')
includeModule('net.neoforged', 'neoforge')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1034
cd NeoForge-pr1034
curl -L https://prmaven.neoforged.net/NeoForge/pr1034/net/neoforged/neoforge/20.6.119-beta-pr-1034-ClayPotBreaking/mdk-pr1034.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
Fixes Decorative Pots dropping themselves instead of Bricks/Sherds when broken with tools like Swords.
Very annoying as to fix it, it requires a few breaking changes on return values.