Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate Block#playerWillDestroy result to Block#playerDestroy #1034

Merged
merged 10 commits into from
Jun 6, 2024

Conversation

TelepathicGrunt
Copy link
Contributor

Fixes Decorative Pots dropping themselves instead of Bricks/Sherds when broken with tools like Swords.

Very annoying as to fix it, it requires a few breaking changes on return values.

Fixes Decorative Pots dropping themselves instead of Bricks/Sherds when broken with tools like Swords.
@TelepathicGrunt TelepathicGrunt added bug A bug or error breaking change Breaks binary compatibility 1.20.6 Targeted at Minecraft 1.20.6 labels May 27, 2024
@TelepathicGrunt TelepathicGrunt self-assigned this May 27, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented May 27, 2024

  • Publish PR to GitHub Packages

Last commit published: f844e9c9c35360746a34a7e764659647e60c6810.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1034' // https://github.com/neoforged/NeoForge/pull/1034
        url 'https://prmaven.neoforged.net/NeoForge/pr1034'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1034.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1034
cd NeoForge-pr1034
curl -L https://prmaven.neoforged.net/NeoForge/pr1034/net/neoforged/neoforge/20.6.119-beta-pr-1034-ClayPotBreaking/mdk-pr1034.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Shadows-of-Fire Shadows-of-Fire merged commit 1e922ff into neoforged:1.20.x Jun 6, 2024
4 checks passed
@TelepathicGrunt TelepathicGrunt deleted the ClayPotBreaking branch June 12, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.6 Targeted at Minecraft 1.20.6 breaking change Breaks binary compatibility bug A bug or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants