Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No CI] Add a gametest for startup configs #1037

Merged
merged 11 commits into from
Jun 5, 2024

Conversation

TelepathicGrunt
Copy link
Contributor

@TelepathicGrunt TelepathicGrunt commented May 29, 2024

Requires neoforged/FancyModLoader#150 (comment) to be merged before gametest merge

Verifies that only Startup config will be loaded in mod init after registration of the config. Teste locally with the FML PR build and it passes
neoforged/FancyModLoader#150 (comment)

@TelepathicGrunt TelepathicGrunt added enhancement New (or improvement to existing) feature or request 1.20.6 Targeted at Minecraft 1.20.6 labels May 29, 2024
@TelepathicGrunt TelepathicGrunt self-assigned this May 29, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented May 29, 2024

  • Publish PR to GitHub Packages

Last commit published: 0f7e56570b4a09f52f3fd103a7f843113a070cbd.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1037' // https://github.com/neoforged/NeoForge/pull/1037
        url 'https://prmaven.neoforged.net/NeoForge/pr1037'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1037.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1037
cd NeoForge-pr1037
curl -L https://prmaven.neoforged.net/NeoForge/pr1037/net/neoforged/neoforge/20.6.118-beta-pr-1037-StartupConfigTest/mdk-pr1037.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@TelepathicGrunt
Copy link
Contributor Author

Linking #723

@Matyrobbrt Matyrobbrt enabled auto-merge (squash) June 5, 2024 10:51
@Matyrobbrt Matyrobbrt merged commit acc3fe8 into neoforged:1.20.x Jun 5, 2024
3 checks passed
@TelepathicGrunt TelepathicGrunt deleted the StartupConfigTest branch June 12, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.6 Targeted at Minecraft 1.20.6 enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants