-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mod description with single apostrophe leads to "Illegal format found" error in log #1561
Labels
triage
Needs triaging and confirmation
Comments
It's still a problem even in 1.21.3. |
Matyrobbrt
added a commit
to Matyrobbrt/NeoForge
that referenced
this issue
Dec 4, 2024
Fixes neoforged#1561 by not formatting mod descriptions, and only querying the translation.
🚀 This issue has been resolved in NeoForge version |
The issue is still present in the 21.1.92 version of Neoforge. Will the fix be ported to 1.21.1? |
Matyrobbrt
added a commit
to Matyrobbrt/NeoForge
that referenced
this issue
Jan 3, 2025
Fixes neoforged#1561 on 1.21.1
Soaryn
pushed a commit
to Soaryn/EnergyHandlerPR
that referenced
this issue
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Minecraft Version: 1.20.5 - 1.21.1. Tested using 1.21.1.
NeoForge Version: Tested using 21.1.61; should happen on any NeoForge with version in range
[20.5.0, 21.1.61]
Logs: N/A, no crashes happen
Steps to Reproduce:
neoforge.mods.toml
given belowmods
directoryDescription of issue:
Similar to #734, if mod description contains an apostrophe (U+0027
APOSTROPHE
),ExtendedMessageFormat
, which is used byFMLTranslations
, will see it as unterminated quoted string and throwIllegalArgumentException
.It was fixed in #686 for 1.20.4, but the fix for 1.20.5 and onward - #851 - only covers mod name, not mod description.
This regression was attested in Argon4W/EveryXHotpot@bb5458c.
The text was updated successfully, but these errors were encountered: