Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The registry check in PacketByteBufs should also be implemented for the holder method #839

Closed
Technici4n opened this issue Apr 23, 2024 · 1 comment · Fixed by #974
Closed

The registry check in PacketByteBufs should also be implemented for the holder method #839

Technici4n opened this issue Apr 23, 2024 · 1 comment · Fixed by #974
Assignees
@Technici4n
Labels
1.21.4 Targeted at Minecraft 1.21.4 cleanup Change that isn't an enhancement or a bug fix

Comments

@Technici4n
Copy link
Member

Else we might miss some synced registries? As far as I can tell at least...

Should also considering collecting the set of registries and checking everything on client or server loading, instead of waiting for the codec to be used and crash in there.
@Technici4n Technici4n added cleanup Change that isn't an enhancement or a bug fix 1.20.5 Targeted at Minecraft 1.20.5 labels Apr 23, 2024
@Technici4n Technici4n self-assigned this Apr 23, 2024
Matyrobbrt added a commit to Matyrobbrt/NeoForge that referenced this issue May 18, 2024
@Matyrobbrt
Implement synced registry check in holder stream codec
5c7efdb 
Closes neoforged#839
@Matyrobbrt Matyrobbrt mentioned this issue May 18, 2024
Merged
@Matyrobbrt Matyrobbrt added 1.21.4 Targeted at Minecraft 1.21.4 and removed 1.20.5 Targeted at Minecraft 1.20.5 labels Dec 5, 2024
@neoforged-releases
Copy link

🚀 This issue has been resolved in NeoForge version 21.4.8-beta, as part of #974.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Technici4n Technici4n

Labels
1.21.4 Targeted at Minecraft 1.21.4 cleanup Change that isn't an enhancement or a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement synced registry check in holder stream codec Matyrobbrt/NeoForge
2 participants
@Technici4n @Matyrobbrt