fix(page_service): page reconstruct error log does not include shard_id label
#10680
+43
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problame
requested review from
VladLazar and
arpad-m
and removed request for
VladLazar
arpad-m
approved these changes
Feb 5, 2025
7425 tests run: 7072 passed, 0 failed, 353 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
9fd667e at 2025-02-05T20:40:33.627Z :recycle: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Before this PR, the
shard_idfield was missing when page_service logs a reconstruct error.This was caused by batching-related refactorings.
Example from staging:
Changes
Delay creation of the handler-specific span until after shard routing
This also avoids the need for the record() call in the pagestream hot path.
Testing
Manual testing with a failpoint that is part of this PR's history but will be squashed away.
Refs
shard_idlabel #10599