You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: guides/CODE_REVIEW.md
+3-3Lines changed: 3 additions & 3 deletions
Original file line number
Diff line number
Diff line change
@@ -7,19 +7,19 @@ There are **\*three types of Code Review** inspired by conference talks by Trish
7
7
8
8
## The Three Types
9
9
10
-
### Draft / Early Feedback
10
+
### Draft / Early Feedback 📝
11
11
12
12
Github has a feature to mark a Pull Request as a draft. Often this won't run CI checks as it is known that it is in a partial working state.
13
13
14
14
These are great to get early feedback about design decisions before sinking too much effort.
15
15
16
-
### Educational
16
+
### Educational 📚
17
17
18
18
Sometimes the person creating the Pull Request is the Subject Matter Expect (SME).
19
19
20
20
They have authority to just push the change through, but it is important for others to see and follow along what the change _**IS**_ and _**WHY**_.
21
21
22
-
### Goalkeeper
22
+
### Goalkeeper 🥅
23
23
24
24
This is probably the more common one that people think of when it comes to code review. They are looking at quality control and trying to stop bugs getting through.
0 commit comments