Skip to content

Commit 40eb523

Browse files
authored
Update CODE_REVIEW.md
1 parent 66ef20d commit 40eb523

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

guides/CODE_REVIEW.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,19 @@ There are **\*three types of Code Review** inspired by conference talks by Trish
77

88
## The Three Types
99

10-
### Draft / Early Feedback
10+
### Draft / Early Feedback 📝
1111

1212
Github has a feature to mark a Pull Request as a draft. Often this won't run CI checks as it is known that it is in a partial working state.
1313

1414
These are great to get early feedback about design decisions before sinking too much effort.
1515

16-
### Educational
16+
### Educational 📚
1717

1818
Sometimes the person creating the Pull Request is the Subject Matter Expect (SME).
1919

2020
They have authority to just push the change through, but it is important for others to see and follow along what the change _**IS**_ and _**WHY**_.
2121

22-
### Goalkeeper
22+
### Goalkeeper 🥅
2323

2424
This is probably the more common one that people think of when it comes to code review. They are looking at quality control and trying to stop bugs getting through.
2525

0 commit comments

Comments
 (0)