100% test-code-coverage for condition.go (#529)

This change is to add 100% code coverage in Porch condition.go. --------- Signed-off-by: Kushal Harish Naidu <[email protected]>
nephio-project · Feb 21, 2024 · c886932 · c886932
1 parent 01cb704
commit c886932
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/controllers/pkg/porch/condition/condition_test.go b/controllers/pkg/porch/condition/condition_test.go
@@ -135,6 +135,20 @@ func TestPackageRevisionIsReady(t *testing.T) {
 			},
 			want: true,
 		},
+		"Condition type not present": {
+			conds: []porchv1alpha1.Condition{
+				{
+					Type:   "myterriblecondition",
+					Status: porchv1alpha1.ConditionStatus(porchv1alpha1.ConditionFalse),
+				},
+			},
+			readyGates: []porchv1alpha1.ReadinessGate{
+				{
+					ConditionType: "notmyterriblecondition",
+				},
+			},
+			want: false,
+		},
 		"Not ready": {
 			conds: []porchv1alpha1.Condition{
 				{