From c88693235a1b15b25359007029d7b0110945449d Mon Sep 17 00:00:00 2001 From: Kushal Harish Naidu <159911459+kushnaidu@users.noreply.github.com> Date: Wed, 21 Feb 2024 12:38:32 +0000 Subject: [PATCH] 100% test-code-coverage for condition.go (#529) This change is to add 100% code coverage in Porch condition.go. --------- Signed-off-by: Kushal Harish Naidu --- controllers/pkg/porch/condition/condition_test.go | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/controllers/pkg/porch/condition/condition_test.go b/controllers/pkg/porch/condition/condition_test.go index 01ba91ca..c26909aa 100644 --- a/controllers/pkg/porch/condition/condition_test.go +++ b/controllers/pkg/porch/condition/condition_test.go @@ -135,6 +135,20 @@ func TestPackageRevisionIsReady(t *testing.T) { }, want: true, }, + "Condition type not present": { + conds: []porchv1alpha1.Condition{ + { + Type: "myterriblecondition", + Status: porchv1alpha1.ConditionStatus(porchv1alpha1.ConditionFalse), + }, + }, + readyGates: []porchv1alpha1.ReadinessGate{ + { + ConditionType: "notmyterriblecondition", + }, + }, + want: false, + }, "Not ready": { conds: []porchv1alpha1.Condition{ {