Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates the dockerfile to run kopf as nonroot #861

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

vjayaramrh
Copy link
Contributor

@vjayaramrh vjayaramrh commented Feb 18, 2025

This PR updates the Dockerfile to run kopf as non-root. It also updates the README to reflect the correct container image being used.

@nephio-prow nephio-prow bot requested review from henderiw and s3wong February 18, 2025 17:01
@vjayaramrh vjayaramrh requested review from dkosteck, radoslawc, efiacor, arora-sagar and liamfallon and removed request for s3wong and henderiw February 18, 2025 17:01
@arora-sagar
Copy link
Contributor

@vjayaramrh Can you provide an MR description?

@gvbalaji
Copy link

Couple of things:

  1. I think this may require a change to the catalog files as well. If so can we do those things together .
  2. Is this tested end to end ( with catalog changes if needed)?

Just making sure all is working well as we are close to cutting the release.

@arora-sagar
Copy link
Contributor

/approve

Copy link
Contributor

@dkosteck dkosteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as long as e2e runs

@vjayaramrh
Copy link
Contributor Author

Looks good as long as e2e runs

I was able to verify as can be seen below

ubuntu@vish-oran2:~/nephio/operators/o2ims-operator/tests$ kind get clusters
edge
mgmt
ubuntu@vish-oran2:~/nephio/operators/o2ims-operator/tests$ kubectl get clusters
NAME   CLUSTERCLASS   PHASE         AGE   VERSION
edge   docker         Provisioned   17m   v1.31.0

@efiacor
Copy link
Collaborator

efiacor commented Feb 18, 2025

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arora-sagar, efiacor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Feb 18, 2025
@nephio-prow nephio-prow bot merged commit 7ce72e0 into nephio-project:main Feb 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants