Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add makefile for o2ims #870

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add makefile for o2ims #870

wants to merge 3 commits into from
+38 −27

Conversation

efiacor
Copy link
Collaborator

@efiacor efiacor commented Feb 24, 2025

Add Makefile docker target.
Update tox and README

@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from efiacor by writing /assign @efiacor in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@efiacor efiacor requested review from radoslawc, vjayaramrh, arora-sagar and dkosteck and removed request for tliron and johnbelamaric February 24, 2025 15:28
@efiacor efiacor self-assigned this Feb 24, 2025
vjayaramrh
vjayaramrh reviewed Feb 26, 2025
View reviewed changes
operators/o2ims-operator/Dockerfile
@@ -23,17 +23,17 @@ RUN addgroup --gid 65535 o2ims && \
# Set working directory
WORKDIR /usr/o2ims

# Copy requirements first and install dependencies
Copy link
Contributor

@vjayaramrh vjayaramrh Feb 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious as to reason for making these changes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Makefile setup for building docker images runs from the root of the repo with a context of ../../
https://github.com/nephio-project/nephio/blob/main/default-docker.mk
Without this change, it's broken.
We should also have some way of executing the tests in each repo through Make, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjayaramrh vjayaramrh vjayaramrh left review comments

@radoslawc radoslawc Awaiting requested review from radoslawc

@arora-sagar arora-sagar Awaiting requested review from arora-sagar

@dkosteck dkosteck Awaiting requested review from dkosteck

@liamfallon liamfallon Awaiting requested review from liamfallon

@Catalin-Stratulat-Ericsson Catalin-Stratulat-Ericsson Awaiting requested review from Catalin-Stratulat-Ericsson

Assignees

@efiacor efiacor

Labels
area/platform sig/release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@efiacor @vjayaramrh