Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable librocksdb-sys to be able to be properly cached in development/CI environment #4792

Open
eval-exec opened this issue Jan 21, 2025 · 1 comment · May be fixed by #4797
Open

Enable librocksdb-sys to be able to be properly cached in development/CI environment #4792

eval-exec opened this issue Jan 21, 2025 · 1 comment · May be fixed by #4797
Labels
t:enhancement Type: Feature, refactoring.

Comments

@eval-exec
Copy link
Collaborator

Feature Request

Is your feature request related to a problem? Please describe.

In the development environment, switching Git branches/commits locally often triggers repeated compilation of librocksdb-sys. If we could cache librocksdb-sys in the development environment, it would significantly improve the development experience.

  1. RocksDB is recompiled despite caching restatedev/restate#463
  2. MystenLabs/sui@85fb661
  3. CI rebuilds librocksdb-sys with a cached rocksdb rust-rocksdb/rust-rocksdb#574
@eval-exec eval-exec added the t:enhancement Type: Feature, refactoring. label Jan 21, 2025
@eval-exec
Copy link
Collaborator Author

https://github.com/rust-rocksdb/rust-rocksdb/blob/86d983987e7cafce90ad8a147b0b325e6007eba6/librocksdb-sys/build.rs#L306
https://doc.rust-lang.org/cargo/guide/cargo-home.html#caching-the-cargo-home-in-ci

@eval-exec eval-exec changed the title Enable librocksdb-sys to be able to be properly cached in development environment Enable librocksdb-sys to be able to be properly cached in development/CI environment Jan 24, 2025
eval-exec added a commit to eval-exec/ckb that referenced this issue Jan 25, 2025
@eval-exec
Enable cache for ckb-librocksdb-sys, fix nervosnetwork#4792
25e8adc
@eval-exec eval-exec linked a pull request Jan 25, 2025 that will close this issue
Draft
eval-exec added a commit to eval-exec/ckb that referenced this issue Jan 25, 2025
@eval-exec
Enable cache for ckb-librocksdb-sys, fix nervosnetwork#4792
8ad60e6 
Signed-off-by: Eval EXEC <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t:enhancement Type: Feature, refactoring.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable cargo build cache for ckb-librocksdb-sys on CI workflows, fix #4792 eval-exec/ckb
1 participant
@eval-exec