Merge pull request #3436 from heplesser/sli2py_281

Port mpitests/issue-281.sli to Python

Author: heplesser

testsuite/mpitests/issue-281.sli

@@ -275,3 +275,14 @@ def assert_correct_results(self, tmpdirpath):
 
             for r in res[1:]:
                 pd.testing.assert_frame_equal(res[0], r)
+
+
+class MPITestAssertCompletes(MPITestWrapper):
+    """
+    Test class that just confirms that the test code completes.
+
+    Therefore, no testing to be done on any results.
+    """
+
+    def assert_correct_results(self, tmpdirpath):
+        pass

testsuite/pytests/sli2py_mpi/mpi_test_wrapper.py

@@ -19,8 +19,6 @@
 # You should have received a copy of the GNU General Public License
 # along with NEST.  If not, see <http://www.gnu.org/licenses/>.
 
-
-import pandas as pd
 import pytest
 from mpi_test_wrapper import MPITestAssertEqual
 
@@ -50,5 +48,5 @@ def test_issue_2119(kind, specs):
     nrn = nest.Create("iaf_psc_alpha", n=4, params={"V_m": nest.CreateParameter(kind, specs)})
 
     pd.DataFrame.from_dict(nrn.get(["global_id", "V_m"])).dropna().to_csv(
-        OTHER_LABEL.format(nest.num_processes, nest.Rank()), index=False
-    )  # noqa: F821
+        OTHER_LABEL.format(nest.num_processes, nest.Rank()), index=False  # noqa: F821
+    )

testsuite/pytests/sli2py_mpi/test_issue_2119.py

@@ -0,0 +1,45 @@
+# -*- coding: utf-8 -*-
+#
+# test_issue_281.py
+#
+# This file is part of NEST.
+#
+# Copyright (C) 2004 The NEST Initiative
+#
+# NEST is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 2 of the License, or
+# (at your option) any later version.
+#
+# NEST is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with NEST.  If not, see <http://www.gnu.org/licenses/>.
+
+
+from mpi_test_wrapper import MPITestAssertCompletes
+
+
+@MPITestAssertCompletes([1, 2, 4])
+def test_issue_281():
+    """
+    Confirm that ConnectLayers works MPI-parallel for fixed fan-out.
+    """
+
+    import nest
+    import pandas as pd
+
+    layer = nest.Create("parrot_neuron", positions=nest.spatial.grid(shape=[3, 3]))
+    nest.Connect(
+        layer,
+        layer,
+        {"rule": "fixed_indegree", "indegree": 8, "allow_multapses": False, "allow_autapses": False},
+        # weights are randomized to check that global RNGs stay in sync
+        {"weight": nest.random.uniform(min=1, max=2)},
+    )
+
+    # Ensure by simulation that global RNGs are still in sync
+    nest.Simulate(10)