Skip to content

Commit 872ab40

Browse files
Merge pull request #13367 from nestjs/revert-13328-fix/redundant-emit-code
Revert "fix(microservices): fix redundant code to emit error"
2 parents f29f932 + f416f5a commit 872ab40

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

packages/microservices/server/server-grpc.ts

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,12 @@ export class ServerGrpc extends Server implements CustomTransportStrategy {
242242
const handler = methodHandler(call.request, call.metadata, call);
243243
const result$ = this.transformToObservable(await handler);
244244

245-
await this.writeObservableToGrpc(result$, call);
245+
try {
246+
await this.writeObservableToGrpc(result$, call);
247+
} catch (err) {
248+
call.emit('error', err);
249+
return;
250+
}
246251
};
247252
}
248253

@@ -381,7 +386,12 @@ export class ServerGrpc extends Server implements CustomTransportStrategy {
381386
const handler = methodHandler(req.asObservable(), call.metadata, call);
382387
const res = this.transformToObservable(await handler);
383388
if (isResponseStream) {
384-
await this.writeObservableToGrpc(res, call);
389+
try {
390+
await this.writeObservableToGrpc(res, call);
391+
} catch (err) {
392+
call.emit('error', err);
393+
return;
394+
}
385395
} else {
386396
const response = await lastValueFrom(
387397
res.pipe(

0 commit comments

Comments
 (0)