fix: move index to src instead of root #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: clean up imports and configs
I have a preference of having my imports alphabetized by package name.
You're absolutely welcome to ask me to revert those changes, it's just
a preference of mine. I updated the build command to use the specific
`tsconfig.build.json` that will allow for the base `tsconfig.json` to
reference all ts files, while the build one only references the `src`
directory. Also switched out `rm -rf` for `rimraf` to take into account
those who may be on windows (and as the package was already installed).
All tests still pass, and the Node REPL pulls in the correct functions
when using `require('./')`.
Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <[email protected]>
…7.19 chore(deps): bump lodash from 4.17.15 to 4.17.19
chore(deps): bump acorn from 5.7.3 to 5.7.4
|
Hi @jmcdo29 and @johnbiundo, I'm running into the same problem as #9, the |
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: clean up imports and configs
I have a preference of having my imports alphabetized by package name.
You're absolutely welcome to ask me to revert those changes, it's just
a preference of mine. I updated the build command to use the specific
tsconfig.build.jsonthat will allow for the basetsconfig.jsontoreference all ts files, while the build one only references the
srcdirectory. Also switched out
rm -rfforrimrafto take into accountthose who may be on windows (and as the package was already installed).
All tests still pass, and the Node REPL pulls in the correct functions
when using
require('./').fix #9