Skip to content

Commit bba5049

Browse files
jeremystretchbctiemann
authored andcommitted
Misc cleanup of the release checklist
1 parent 2951574 commit bba5049

File tree

2 files changed

+28
-4
lines changed

2 files changed

+28
-4
lines changed

docs/development/release-checklist.md

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ This documentation describes the process of packaging and publishing a new NetBo
88

99
While major releases generally introduce some very substantial change to the application, they are typically treated the same as minor version increments for the purpose of release packaging.
1010

11+
For patch releases (e.g. upgrading from v4.2.2 to v4.2.3), begin at the [patch releases](#patch-releases) heading below. For minor or major releases, complete the entire checklist.
12+
1113
## Minor Version Releases
1214

1315
### Address Constrained Dependencies
@@ -85,7 +87,20 @@ In cases where upgrading a dependency to its most recent release is breaking, it
8587

8688
### Update UI Dependencies
8789

88-
Check whether any UI dependencies (JavaScript packages, fonts, etc.) need to be updated by running `yarn outdated` from within the `project-static/` directory. [Upgrade these dependencies](./web-ui.md#updating-dependencies) as necessary, then run `yarn bundle` to generate the necessary files for distribution.
90+
Check whether any UI dependencies (JavaScript packages, fonts, etc.) need to be updated by running `yarn outdated` from within the `project-static/` directory. [Upgrade these dependencies](./web-ui.md#updating-dependencies) as necessary, then run `yarn bundle` to generate the necessary files for distribution:
91+
92+
```
93+
$ yarn bundle
94+
yarn run v1.22.19
95+
$ node bundle.js
96+
✅ Bundled source file 'styles/external.scss' to 'netbox-external.css'
97+
✅ Bundled source file 'styles/netbox.scss' to 'netbox.css'
98+
✅ Bundled source file 'styles/svg/rack_elevation.scss' to 'rack_elevation.css'
99+
✅ Bundled source file 'styles/svg/cable_trace.scss' to 'cable_trace.css'
100+
✅ Bundled source file 'index.ts' to 'netbox.js'
101+
✅ Copied graphiql files
102+
Done in 1.00s.
103+
```
89104

90105
### Rebuild the Device Type Definition Schema
91106

@@ -116,16 +131,22 @@ Then, compile these portable (`.po`) files for use in the application:
116131

117132
### Update Version and Changelog
118133

119-
* Update the version and published date in `release.yaml` with the current version & date. Add a designation (e.g.g `beta1`) if applicable.
134+
* Update the version number and date in `netbox/release.yaml`. Add or remove the designation (e.g. `beta1`) if applicable.
120135
* Update the example version numbers in the feature request and bug report templates under `.github/ISSUE_TEMPLATES/`.
121-
* Replace the "FUTURE" placeholder in the release notes with the current date.
136+
* Add a section for this release at the top of the changelog page for the minor version (e.g. `docs/release-notes/version-4.2.md`) listing all relevant changes made in this release.
137+
138+
!!! tip
139+
Put yourself in the shoes of the user when recording change notes. Focus on the effect that each change has for the end user, rather than the specific bits of code that were modified in a PR. Ensure that each message conveys meaning absent context of the initial feature request or bug report. Remember to include key words or phrases (such as exception names) that can be easily searched.
122140

123141
### Submit a Pull Request
124142

125143
Commit the above changes and submit a pull request titled **"Release vX.Y.Z"** to merge the current release branch (e.g. `release-vX.Y.Z`) into `main`. Copy the documented release notes into the pull request's body.
126144

127145
Once CI has completed and a colleague has reviewed the PR, merge it. This effects a new release in the `main` branch.
128146

147+
!!! warning
148+
To ensure a streamlined review process, the pull request for a release **must** be limited to the changes outlined in this document. A release PR must never include functional changes to the application: Any unrelated "cleanup" needs to be captured in a separate PR prior to the release being shipped.
149+
129150
### Create a New Release
130151

131152
Create a [new release](https://github.com/netbox-community/netbox/releases/new) on GitHub with the following parameters.

docs/development/translations.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ To download translated strings automatically, you'll need to:
3030
1. Install the [Transifex CLI client](https://github.com/transifex/cli)
3131
2. Generate a [Transifex API token](https://app.transifex.com/user/settings/api/)
3232

33-
Once you have the client set up, run the following command:
33+
Once you have the client set up, run the following command from the project root (e.g. `/opt/netbox/`):
3434

3535
```no-highlight
3636
TX_TOKEN=$TOKEN tx pull
@@ -46,6 +46,9 @@ Once retrieved, the updated strings need to be compiled into new `.mo` files so
4646

4747
Once any new `.mo` files have been generated, they need to be committed and pushed back up to GitHub. (Again, this is typically done as part of publishing a new NetBox release.)
4848

49+
!!! tip
50+
Run `git status` to check that both `*.mo` & `*.po` files have been updated as expected.
51+
4952
## Proposing New Languages
5053

5154
If you'd like to add support for a new language to NetBox, the first step is to [submit a GitHub issue](https://github.com/netbox-community/netbox/issues/new?assignees=&labels=type%3A+translation&projects=&template=translation.yaml) to capture the proposal. While we'd like to add as many languages as possible, we do need to limit the rate at which new languages are added. New languages will be selected according to community interest and the number of volunteers who sign up as translators.

0 commit comments

Comments
 (0)