Skip to content

Script results log_threshold should default to Default #18241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
llamafilm opened this issue Dec 16, 2024 · 0 comments · Fixed by #18501
Closed

Script results log_threshold should default to Default #18241

llamafilm opened this issue Dec 16, 2024 · 0 comments · Fixed by #18501
Assignees
@bctiemann @renatoalmeidaoliveira
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@llamafilm
Copy link
Contributor

llamafilm commented Dec 16, 2024 •
edited
Loading

Deployment Type

NetBox Enterprise

Triage priority

I'm a NetBox Labs customer

NetBox Version

v4.1.7

Python Version

3.12

Steps to Reproduce

  1. Run a custom script
  2. View the results page /extras/scripts/results/xxxxx/

Expected Behavior

The new "log threshold" setting should use "Default" by default.

Observed Behavior

The default value is "Debug (All)".
image

I use user-facing custom scripts extensively, and it's important for users to quickly review the output to make sure there are no errors. Debug output is overwhelming to look at most of the time. I suggest making the default value an option in user and/or global preferences.
@llamafilm llamafilm added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Dec 16, 2024
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Dec 27, 2024
Merged
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Feb 3, 2025
@bctiemann bctiemann mentioned this issue Feb 21, 2025
Merged
bctiemann pushed a commit that referenced this issue Mar 6, 2025
@renatoalmeidaoliveira @bctiemann
Fixes: #18241 - Script results log_threshold should default to Default (
7797e08 
#18501)

* Changed LogLevelChoices order; Changed ScriptResultView to select LogLevelChoices to LOG_DEFAULT and setup the html template to put (All) in the last one

* Change LogLevelChoices in ScriptResultView get_table method

* Remove default option, add Default string to INFO

* Fix scripts.py and reports.py to reflect removing DEFAULT level

* fix linting
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bctiemann bctiemann

@renatoalmeidaoliveira renatoalmeidaoliveira

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes: #18241 - Script results log_threshold should default to Default renatoalmeidaoliveira/netbox
4 participants
@llamafilm @bctiemann @jeremystretch @renatoalmeidaoliveira