NGSTACK-842 extract configuration service

Author: petarjakopec

bundle/Configuration/ScheduledVisibilityConfiguration.php

@@ -0,0 +1,39 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Netgen\Bundle\IbexaScheduledVisibilityBundle\Configuration;
+
+use Netgen\Bundle\IbexaScheduledVisibilityBundle\ScheduledVisibility\Registry;
+use Netgen\Bundle\IbexaScheduledVisibilityBundle\ScheduledVisibility\ScheduledVisibilityInterface;
+
+final class ScheduledVisibilityConfiguration
+{
+    public function __construct(
+        private readonly Registry $registry,
+        private readonly string $type,
+        private readonly bool $enabled,
+        private readonly bool $allContentTypes,
+        private readonly array $allowedContentTypes,
+    ) {}
+
+    public function getHandler(): ScheduledVisibilityInterface
+    {
+        return $this->registry->get($this->type);
+    }
+
+    public function isEnabled(): bool
+    {
+        return $this->enabled;
+    }
+
+    public function isAllContentTypes(): bool
+    {
+        return $this->allContentTypes;
+    }
+
+    public function getAllowedContentTypes(): array
+    {
+        return $this->allowedContentTypes;
+    }
+}

bundle/Resources/config/services.yaml

@@ -19,6 +19,10 @@ services:
             - { name: monolog.logger, channel: ngscheduledvisibility }
 
     Netgen\Bundle\IbexaScheduledVisibilityBundle\Service\ScheduledVisibilityService:
+        arguments:
+            - '@Netgen\Bundle\IbexaScheduledVisibilityBundle\Service\ScheduledVisibilityConfiguration'
+
+    Netgen\Bundle\IbexaScheduledVisibilityBundle\Service\ScheduledVisibilityConfiguration:
         arguments:
             - '@Netgen\Bundle\IbexaScheduledVisibilityBundle\ScheduledVisibility\Registry'
             - '%netgen_ibexa_scheduled_visibility.type%'

bundle/Service/ScheduledVisibilityService.php

@@ -9,20 +9,16 @@
 use Ibexa\Contracts\Core\Repository\Values\Content\Field;
 use Ibexa\Core\FieldType\Date\Value as DateValue;
 use Ibexa\Core\FieldType\DateAndTime\Value as DateAndTimeValue;
+use Netgen\Bundle\IbexaScheduledVisibilityBundle\Configuration\ScheduledVisibilityConfiguration;
 use Netgen\Bundle\IbexaScheduledVisibilityBundle\Enums\VisibilityUpdateResult;
-use Netgen\Bundle\IbexaScheduledVisibilityBundle\ScheduledVisibility\Registry;
 use OutOfBoundsException;
 
 use function in_array;
 
 final class ScheduledVisibilityService
 {
     public function __construct(
-        private readonly Registry $registry,
-        private readonly string $type,
-        private readonly bool $enabled,
-        private readonly bool $allContentTypes,
-        private readonly array $allowedContentTypes,
+        private ScheduledVisibilityConfiguration $configurationService,
     ) {}
 
     /**
@@ -34,7 +30,7 @@ public function updateVisibilityIfNeeded(Content $content): VisibilityUpdateResu
             return VisibilityUpdateResult::NoChange;
         }
 
-        $handler = $this->registry->get($this->type);
+        $handler = $this->configurationService->getHandler();
 
         if ($this->shouldBeHidden($content) && !$handler->isHidden($content)) {
             $handler->hide($content);
@@ -53,13 +49,13 @@ public function updateVisibilityIfNeeded(Content $content): VisibilityUpdateResu
 
     public function accept(Content $content): bool
     {
-        $enabled = $this->enabled;
-        if (!$enabled) {
+        if (!$this->configurationService->isEnabled()) {
             return false;
         }
 
-        $allowedAll = $this->allContentTypes;
-        $allowedContentTypes = $this->allowedContentTypes;
+        $allowedAll = $this->configurationService->isAllContentTypes();
+        $allowedContentTypes = $this->configurationService->getAllowedContentTypes();
+
         $contentType = $content->getContentType();
         if (!$allowedAll && !in_array($contentType->identifier, $allowedContentTypes, true)) {
             return false;