fix: correctly disable ISR disk flushing #1190
Conversation
|
✔️ Deploy Preview for netlify-plugin-nextjs-demo ready! 🔨 Explore the source changes: c934ad1 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/61fbc0243c301700088777e8 😎 Browse the preview: https://deploy-preview-1190--netlify-plugin-nextjs-demo.netlify.app |
|
✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready! 🔨 Explore the source changes: c934ad1 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61fbc024e461300007c51ce7 😎 Browse the preview: https://deploy-preview-1190--netlify-plugin-nextjs-static-root-demo.netlify.app |
|
✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready! 🔨 Explore the source changes: c934ad1 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61fbc02402cefb0007c49a7c 😎 Browse the preview: https://deploy-preview-1190--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app |
github-actions
bot
added
the
type: chore
|
✔️ Deploy Preview for netlify-plugin-nextjs-export-demo ready! 🔨 Explore the source changes: c934ad1 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/61fbc024ce42e70008ed9cc8 😎 Browse the preview: https://deploy-preview-1190--netlify-plugin-nextjs-export-demo.netlify.app |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
ascorbic
changed the title
ascorbic
removed
the
type: chore
ascorbic
changed the title
Summary
We need to patch the Next server source file because Next doesn't allow non-Vercel hosts to disable flushing of ISR pages to disk. In a recent update, the code in question was moved from
next-servertobase-server, meaning that the patch was not applied. This meant that ISR pages were serving the original built files rather than the updated version. This caused #1189 and possibly #1162.This PR makes the patching process more robust, and introduces tests to ensure the patching is working in future
Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Possibly #1189 and #1162, but I'm not going to auto-close until the fix is confirmed.
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.