Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove confusing error log #1199

Merged
merged 2 commits into from
Feb 7, 2022
Merged

fix: remove confusing error log #1199

merged 2 commits into from
Feb 7, 2022

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Feb 7, 2022

Summary

The plugin iterates through a list of module files until it finds one it can resolve. This PR removes a confusing error message displayed when one of those files was not resolved, because this is not really an error.

Test plan

Ensure a build completes without error

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Fixes #1198

capybara

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@netlify
Copy link

netlify bot commented Feb 7, 2022

✔️ Deploy Preview for netlify-plugin-nextjs-demo ready!

🔨 Explore the source changes: 7b745c3

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/620145705d197b0007bccf85

😎 Browse the preview: https://deploy-preview-1199--netlify-plugin-nextjs-demo.netlify.app

@netlify
Copy link

netlify bot commented Feb 7, 2022

✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

🔨 Explore the source changes: 7b745c3

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/6201457053adad00081ef5b3

😎 Browse the preview: https://deploy-preview-1199--netlify-plugin-nextjs-static-root-demo.netlify.app

@netlify
Copy link

netlify bot commented Feb 7, 2022

✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

🔨 Explore the source changes: 7b745c3

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/62014570ec072c0007e29129

😎 Browse the preview: https://deploy-preview-1199--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Feb 7, 2022
@netlify
Copy link

netlify bot commented Feb 7, 2022

✔️ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

🔨 Explore the source changes: 7b745c3

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/62014570b13ef80007cf52fe

😎 Browse the preview: https://deploy-preview-1199--netlify-plugin-nextjs-export-demo.netlify.app

@cypress
Copy link

cypress bot commented Feb 7, 2022



Test summary

2 0 0 0


Run details

Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit e839574 ℹ️
Started Feb 7, 2022 4:16 PM
Ended Feb 7, 2022 4:17 PM
Duration 01:10 💡
OS Linux Ubuntu - 20.04
Browser Chrome 97

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Feb 7, 2022



Test summary

20 2 0 0


Run details

Project netlify-plugin-nextjs-default-demo
Status Failed
Commit e839574 ℹ️
Started Feb 7, 2022 4:16 PM
Ended Feb 7, 2022 4:17 PM
Duration 01:34 💡
OS Linux Ubuntu - 20.04
Browser Chrome 97

View run in Cypress Dashboard ➡️


Failures

middleware.spec.ts Failed
1 Middleware > should properly load custom headers
preview.spec.ts Failed
1 Preview Mode > enters and exits preview mode

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Feb 7, 2022



Test summary

7 0 0 0


Run details

Project netlify-plugin-nextjs-static-demo
Status Passed
Commit e839574 ℹ️
Started Feb 7, 2022 4:16 PM
Ended Feb 7, 2022 4:17 PM
Duration 01:17 💡
OS Linux Ubuntu - 20.04
Browser Chrome 97

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "Cannot find module 'next/dist/server/base-server'" with plugin 4.2.4 and Next 11.x
2 participants