-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove confusing error log #1199
Conversation
✔️ Deploy Preview for netlify-plugin-nextjs-demo ready! 🔨 Explore the source changes: 7b745c3 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/620145705d197b0007bccf85 😎 Browse the preview: https://deploy-preview-1199--netlify-plugin-nextjs-demo.netlify.app |
✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready! 🔨 Explore the source changes: 7b745c3 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/6201457053adad00081ef5b3 😎 Browse the preview: https://deploy-preview-1199--netlify-plugin-nextjs-static-root-demo.netlify.app |
✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready! 🔨 Explore the source changes: 7b745c3 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/62014570ec072c0007e29129 😎 Browse the preview: https://deploy-preview-1199--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app |
✔️ Deploy Preview for netlify-plugin-nextjs-export-demo ready! 🔨 Explore the source changes: 7b745c3 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/62014570b13ef80007cf52fe 😎 Browse the preview: https://deploy-preview-1199--netlify-plugin-nextjs-export-demo.netlify.app |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Summary
The plugin iterates through a list of module files until it finds one it can resolve. This PR removes a confusing error message displayed when one of those files was not resolved, because this is not really an error.
Test plan
Ensure a build completes without error
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #1198
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.