fix: correctly cache when using next export
#1223
Conversation
|
✔️ Deploy Preview for netlify-plugin-nextjs-demo ready! 🔨 Explore the source changes: 7c31d90 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/620e5b19a7630300073fa012 😎 Browse the preview: https://deploy-preview-1223--netlify-plugin-nextjs-demo.netlify.app |
|
✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready! 🔨 Explore the source changes: 7c31d90 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/620e5b194ed53c0008dc7f59 😎 Browse the preview: https://deploy-preview-1223--netlify-plugin-nextjs-static-root-demo.netlify.app |
|
✔️ Deploy Preview for netlify-plugin-nextjs-export-demo ready! 🔨 Explore the source changes: 7c31d90 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/620e5b1933cb940008ca9f5f 😎 Browse the preview: https://deploy-preview-1223--netlify-plugin-nextjs-export-demo.netlify.app |
|
✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready! 🔨 Explore the source changes: 7c31d90 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/620e5b19cb6e5400081bf373 😎 Browse the preview: https://deploy-preview-1223--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| console.log('Next.js cache restored.') | ||
| } else { | ||
| console.log('No Next.js cache to restore.') | ||
| } | ||
| } | ||
|
|
||
| export const saveCache = async ({ cache, publish }) => { | ||
| const cacheDir = join(publish, 'cache') | ||
|
|
||
| const buildManifest = join(publish, 'build-manifest.json') |
There was a problem hiding this comment.
Just to confirm: was removing build-manifest.json as the digests option intentional?
There was a problem hiding this comment.
Yeah, because it seems like it's not an accurate indicator of whether the cache has changed.
ascorbic
force-pushed
the
mk.export-cache
branch
from
8f4aaec to
7c31d90
Compare
Summary
Currently we look for the cache inside the publish directory. Normally this is fine, because the publish directory is
.next, however when usingnext exportit has a different publish directory. This PR attempts to find the cache directory elsewhere if the site is using next export.Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #1192
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.