fix: use correct publishDir when building from CLI with cwd option #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔮 Deploy Preview for netlify-plugin-nextjs-demo canceled.
|
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👷 Deploy request for netlify-plugin-nextjs-static-root-demo pending review.Visit the deploys page to approve it
|
5 tasks
ascorbic
reviewed
Mar 15, 2022
ascorbic
previously approved these changes
Mar 16, 2022
ascorbic
changed the title
ascorbic
previously approved these changes
Mar 16, 2022
|
Anything else to do here for merging? Wasn't sure with the failing checks and warning about the branch being out of date |
|
The failing e2e tests are expected! We just realized that secrets don't get shared to forks. |
|
Will them failing keep the automerge from working? |
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
ascorbic
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When building using the Netlify CLI with the cwd option, the
PUBLISH_DIRis an absolute pathWithout the cwd option, it is a relative path
If it's an absolute path, it's a bug to join it on the
cwd, this ends up injecting a path into the function that leads outside of the project. This change checks for if it's an absolute path before joining it.I also changed the value logged when the build cannot be found to print the full path instead of the relative path from the cwd; while debugging this, the value printing out for me was just "../.." which wasn't helpful.
Test plan
I've tested against the reproduction I made here https://github.com/lourd/netlify-cli-repro/blob/main/package.json#L9 and it works. I'm not sure how to make an automated demo test using the CLI.
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Closes #1258.
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.