Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change working directory to site root in SSR #1265

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Mar 16, 2022

Summary

Next.js expects the cwd to be the site root. In some cases with monorepos that isn't the case, which can cause problems with packages that expect to be able to resolve things such as config files relative to the root. This PR changes the working directory to the site root as part of the handler bootstrap.

Test plan

  1. Visit /api/hello in the default deploy preview, and check that cwd is the root of the demo site (demos/default)

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

capybara and babies

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@netlify
Copy link

netlify bot commented Mar 16, 2022

🤘 Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 8542308
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/6231dbf44ed11200096af151
😎 Deploy Preview https://deploy-preview-1265--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code... QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ascorbic ascorbic requested a review from a team March 16, 2022 12:45
@ascorbic ascorbic self-assigned this Mar 16, 2022
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Mar 16, 2022
@netlify
Copy link

netlify bot commented Mar 16, 2022

🧡 Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 8542308
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/6231dbf4e6dbe90009856330
😎 Deploy Preview https://deploy-preview-1265--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code... QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 16, 2022

🔥 Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 8542308
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/6231dbf4eb0f5300089c7720
😎 Deploy Preview https://deploy-preview-1265--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code... QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 16, 2022

😁 Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 8542308
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/6231dbf474271e0008f6a40c
😎 Deploy Preview https://deploy-preview-1265--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code... QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Mar 16, 2022



Test summary

22 0 0 0


Run details

Project netlify-plugin-nextjs-default-demo
Status Passed
Commit e10053e ℹ️
Started Mar 16, 2022 12:49 PM
Ended Mar 16, 2022 12:50 PM
Duration 01:21 💡
OS Linux Ubuntu - 20.04
Browser Chrome 98

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Mar 16, 2022



Test summary

2 0 0 0


Run details

Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit e10053e ℹ️
Started Mar 16, 2022 12:50 PM
Ended Mar 16, 2022 12:51 PM
Duration 01:09 💡
OS Linux Ubuntu - 20.04
Browser Chrome 98

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Mar 16, 2022



Test summary

7 0 0 0


Run details

Project netlify-plugin-nextjs-static-demo
Status Passed
Commit e10053e ℹ️
Started Mar 16, 2022 12:50 PM
Ended Mar 16, 2022 12:52 PM
Duration 01:16 💡
OS Linux Ubuntu - 20.04
Browser Chrome 98

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link

@krider2010 krider2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@kodiakhq kodiakhq bot merged commit 8463bbc into main Mar 16, 2022
@kodiakhq kodiakhq bot deleted the mk/cwd-root branch March 16, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants