Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update README with note about version compatibility #167

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

lindsaylevine
Copy link

Fixes #166

@lindsaylevine lindsaylevine added the type: chore work needed to keep the product and development running smoothly label Mar 21, 2021
Copy link

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might make it easier for our users to write the supported versions explicitly in the README.

Please let me know what you think.

@lindsaylevine lindsaylevine force-pushed the ll/vers-compat-readme-update branch from 63cdc6c to 6dfb262 Compare March 21, 2021 11:17
@lindsaylevine lindsaylevine requested a review from erezrokah March 21, 2021 11:17
@lindsaylevine lindsaylevine merged commit 9c15988 into main Mar 22, 2021
@lindsaylevine lindsaylevine deleted the ll/vers-compat-readme-update branch March 22, 2021 12:50

For breaking Next.js releases, all Next.js versions before the breaking release will be locked to the last working plugin version:

Next.js < 10.0.6 is locked to plugin version 1.1.3. To use the latest plugin version, upgrade to Next.js >= 10.0.6.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we replace 1.1.3 by 1.*.* or v1 to avoid updating the README.md when new backports are made to v1?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how often are new backports gonna be made? i feel like it should be rare enough that it's not a big deal, people should probably just be upgrading

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netlify using outdated plugin-nextjs version 1.1.3
3 participants