-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle cases of chunked middleware #2574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report 0%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
437c150
to
ec5e1f5
Compare
serhalp
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Custom user webpack config can result in middleware being chunked. Our middleware wrapper assumes unchunked case and will fail at edge function bundling step if it is chunked and result in user facing error like this:
Minified generated code for chunked case looks like this:
And middleware manifest looking like this (relevant subset of it) :
Only one of those chunks actually seeds
_ENTRIES
, so the fix here is inspecting_ENTRIES
object and finding which key starts withmiddleware_${name}
instead of just trying to guess exact key. It will still find entry if it's not chunked.Documentation
Tests
One of middleware related fixtures adjusted to reproduce the issue (force middleware chunking), which result in our tests reproducing reported issue - https://github.com/netlify/next-runtime/actions/runs/10558115993/job/29246960707?pr=2574#step:13:295
Relevant links (GitHub issues, etc.) or a picture of cute animal
https://linear.app/netlify/issue/FRP-1270/unable-to-bundle-middleware