Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency fs-extra to v10 #280

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 10, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
fs-extra ^9.1.0 -> ^10.0.0 age adoption passing confidence

Release Notes

jprichardson/node-fs-extra

v10.0.0

Compare Source

Breaking changes

The following changes, although technically semver-major, will not affect the vast majority of users:

  • Ensure correct type when destination exists for ensureLink*()/ensureSymlink*() (#​826, #​786, #​870)
  • Error when attempting to copy*() unknown file type (#​880)
  • Remove undocumented options for remove*() (#​882)
Improvements
  • Allow changing case of filenames with move*(), even on technically case-insensitive filesystems (#​759, #​801)
  • Use native fs.rm*() for remove*() in environments that support it (#​882, #​806)
  • Improve emptyDir() performance (#​885)
Bugfixes
  • Ensure copy*()'s filter function is not called more than necessary (#​883, #​809)
  • Fix move*() raising EPERM error when moving a file to the root of a drive on Windows (#​897, #​819)
Miscellaneous changes

Configuration

📅 Schedule: "before 3am on Monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label May 10, 2021
@lindsaylevine
Copy link

this requires node 12+ - @erezrokah when's safe to drop support for node 10 you think?

@erezrokah
Copy link

erezrokah commented May 12, 2021

I see several options:

  1. You can drop Node.js 10 support (behind a major version) and use the compatibility field like the Lighthouse plugin:
    https://github.com/netlify/plugins/blob/99232ce2096d3db7e27f0f1f62a3f3dd34e2c18d/site/plugins.json#L364
  2. Wait for us to drop Node.js 10 support, @JGAntunes is currently working on dropping Node.js 8. I don't think we have a definitive timeline yet
  3. Remove the usage of fs-extra from codebase. From https://github.com/netlify/netlify-plugin-nextjs/search?p=1&q=fs-extra I don't see a very compelling reason to keep it, but I might be missing something

Personally I prefer 3.

@renovate renovate bot force-pushed the renovate/fs-extra-10.x branch 2 times, most recently from 60e5220 to 755e5fa Compare May 14, 2021 21:21
@renovate renovate bot force-pushed the renovate/fs-extra-10.x branch from 755e5fa to edcb2a9 Compare May 18, 2021 15:52
@ascorbic
Copy link
Contributor

We're going to hold off on this until we can drop Node 10, which we'll do when Next does

@renovate renovate bot force-pushed the renovate/fs-extra-10.x branch from edcb2a9 to cc1f22a Compare June 28, 2021 10:51
@renovate renovate bot force-pushed the renovate/fs-extra-10.x branch from cc1f22a to df28b05 Compare June 28, 2021 12:24
@ascorbic
Copy link
Contributor

Let's close this PR. We can get do the upgrade manually when we drop Node 10

@ascorbic ascorbic closed this Jun 28, 2021
@renovate
Copy link
Contributor Author

renovate bot commented Jun 28, 2021

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 10.x releases. However, if you upgrade to 10.x manually then Renovate will then reenable updates for minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot deleted the renovate/fs-extra-10.x branch June 28, 2021 13:11
@erezrokah
Copy link

Opened a follow up PR #452 so revovate stops bugging on future updates

serhalp pushed a commit that referenced this pull request Apr 5, 2024
…k to pathname (#280)

* test: add i18n+basePath page router fixture, add tests for cache-tag correctness

* fix: use response cache key for tag manifest first before falling back to pathname

* fix: mark request as on-demand revalidate so we purge cdn cache tag after updating response cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants