fix: add details to copyNextAssets error messaging #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help with debugging across environments
lindsaylevine
added
type: feature
|
@tmilewski hey tom! i was gonna do this for you but since you PR'd from a fork.. can you do me a favor and rebase this with main so we can get the tests passing? thanks so much :) |
|
turns out matt could do it! we'll merge when everything passes 🙏 thanks matt!!! |
|
@lindsaylevine Apologies for falling off... I've been neck-deep trying to get a project out. Thanks to you and @ascorbic for getting this through! |
|
no worries, of course!!! |
serhalp
pushed a commit
that referenced
this pull request
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wound up spending an inordinate amount of time trying to debug issues when attempting to deploy with NX while using this plugin.
Having these specific details would have saved me a lot of trouble. Hopefully, this change will help others down the line.
Thanks for all of your work!