Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: don't fail the build if the site doesn't match the requirements #93

Closed
erezrokah opened this issue Feb 1, 2021 · 1 comment · Fixed by #94
Closed

Feature: don't fail the build if the site doesn't match the requirements #93

erezrokah opened this issue Feb 1, 2021 · 1 comment · Fixed by #94
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@erezrokah
Copy link

The plugin currently fails the build if:

  1. This site is not a next site
  2. The site is a static HTML export Next.js site
  3. The site has next-on-netlify installed
  4. The site configures a target other than serverless or experimental-serverless-trace

Per https://github.com/netlify/pod-workflow/issues/121#issuecomment-763411132 I suggest to change it to only fail if it's not a next site.

For all other cases we can print a relevant message and do nothing.
@erezrokah erezrokah added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Feb 1, 2021
@lindsaylevine
Copy link

thanks for opening this officially!! this has been on the dx internal board/on my radar for several weeks but it's good to have here as well!!! :)

This was referenced Feb 2, 2021
Closed
Merged
@lindsaylevine lindsaylevine mentioned this issue Feb 4, 2021
Merged
serhalp pushed a commit that referenced this issue Apr 5, 2024
@orinokai
feat: swap publish/static dirs (#93)
a31816e 
* feat: swap publish/static dirs

* fix: move redirects to onPostBuild

* chore: add test for static assets

* chore: fix e2e test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update failure points in plugin to do nothing instead opennextjs/opennextjs-netlify
2 participants
@erezrokah @lindsaylevine