From 0dccd0add357a1fe396a0c360ea841a52fac0e75 Mon Sep 17 00:00:00 2001
From: Norman Maurer <norman_maurer@apple.com>
Date: Tue, 29 Oct 2024 09:02:47 +0100
Subject: [PATCH] Use -DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded (#751)

Motivation:

We should use Use -DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded as a
replacement for /MT

Modifications:

Use cmake specific flag

Result:

Cleanup build
---
 codec-native-quic/pom.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/codec-native-quic/pom.xml b/codec-native-quic/pom.xml
index 74ef57cc..26a25a02 100644
--- a/codec-native-quic/pom.xml
+++ b/codec-native-quic/pom.xml
@@ -90,10 +90,9 @@
         <cargoTarget>--target=${quicheTarget}</cargoTarget>
         <quicheBuildDir>${quicheSourceDir}/target/${quicheTarget}/release</quicheBuildDir>
         <cmakeAsmFlags />
-        <!-- On Windows, build with /MT for static linking -->
-        <cmakeCFlags>/MT</cmakeCFlags>
+        <cmakeCFlags />
         <!-- Disable one warning to be able to build on windows -->
-        <cmakeCxxFlags>/MT /wd4091</cmakeCxxFlags>
+        <cmakeCxxFlags>/wd4091</cmakeCxxFlags>
         <libssl>ssl.lib</libssl>
         <libcrypto>crypto.lib</libcrypto>
         <libquiche>quiche.lib</libquiche>
@@ -705,6 +704,7 @@
                           <env key="MACOSX_DEPLOYMENT_TARGET" value="${macosxDeploymentTarget}" />
                           <arg value="-DCMAKE_POSITION_INDEPENDENT_CODE=TRUE" />
                           <arg value="-DCMAKE_BUILD_TYPE=Release" />
+                          <arg value="-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded" />
                           <arg value="-DCMAKE_ASM_FLAGS=${cmakeAsmFlags}" />
                           <arg value="-DCMAKE_C_FLAGS_RELEASE=${cmakeCFlags}" />
                           <arg value="-DCMAKE_CXX_FLAGS_RELEASE=${cmakeCxxFlags}" />