refactor(services): removes save utility in favor of using netzo.api.<method>() instead

Author: miguelrk

Diff for: mod.ts

@@ -4,7 +4,7 @@ import {
   http,
   // sse,
   // websocket,
-  // kv,
+  kv,
 } from "./src/mod.ts";
 
 /**
@@ -38,5 +38,6 @@ export const Netzo = (options: NetzoOptions) => {
     getApiKey: () => apiKey,
     services: createServices(api),
     http,
+    kv,
   }
 };

Diff for: src/kv/mod.test.ts

@@ -23,17 +23,14 @@ Deno.test("netzo.kv", () => {
   assertExists(netzo.kv)
 })
 
-Deno.test("kv", () => {
+Deno.test("kv", async () => {
   assertExists(kv)
 
-  // let receiver = new Proxy({}, receiverHandler)
-  // let provider = new Proxy({}, providerHandler)
+  kv.local.prop = await kv.remote.prop   // await it here
+  console.log(await kv.local.prop)
 
-  // receiver.prop = await provider.prop   // await it here
-  // console.log(await receiver.prop)
+  kv.local.another = kv.remote.another   // direct assign here, no await
+  console.log(await kv.local.another)
 
-  // receiver.another = provider.another   // direct assign here, no await
-  // console.log(await receiver.another)
-
-  // await provider.set("value")        // store someting remotely. up to you to decide await or not
+  kv.remote.foo = "bar" // store someting remotely. up to you to decide await or not
 })

Diff for: src/kv/mod.ts

@@ -28,7 +28,7 @@ const providerHandler: ProxyHandler<any> = {
   get: async (_target, _name) => {
     console.log('load someting from remote...')
     return await new Promise((res, rej) => {
-      setTimeout(() => res(42), 4200)
+      setTimeout(() => res("Hello world"), 1000)
     })
   },
   set: (_obj, _prop, _value) => {

Diff for: src/services/mod.test.ts

@@ -15,7 +15,6 @@ Deno.test("service", () => {
   assertExists(service.client)
   assertExists(service.requests)
   assertExists(service.item)
-  assertExists(service.save)
 })
 
 Deno.test("service.client.todos.get()", async () => {

Diff for: src/services/mod.ts

@@ -20,20 +20,8 @@ const getClient = (item: ItemService): Client => {
   }
 }
 
-const createServiceRequests = ({ api, _id, item, save }: any) => {
+const createServiceRequests = ({ api, _id, item }: any) => {
   return (requestItem: ItemServiceRequest, index: number) => {
-    const saveRequest = async (data: ItemServiceRequest) => {
-      const requests: ItemServiceRequest[] = [
-        ...item.requests.slice(0, index),
-        data,
-        ...item.requests.slice(index + 1)
-      ]
-      const newItem = await save({ requests })
-      for (const [key, value] of Object.entries(newItem)) {
-        item[key] = value // mutate local object to update with changes
-      }
-      return requestItem
-    }
     // TODO: reuse existing client (of service) if possible
     // or at least $fetch/useFetch/unfetch client which supports
     // entire service request options (for example hooks, etc.)
@@ -52,11 +40,11 @@ const createServiceRequests = ({ api, _id, item, save }: any) => {
     const proxy = new Proxy((() => { }), {
       /** Select existing by name: "service.requests('getAllTodos')" */
       get: (_target, _id): ServiceRequest => {
-        return { invoke: createInvoke(item), item, save: saveRequest }
+        return { invoke: createInvoke(item), item }
       },
       /** Creating a new service by passing in options */
       apply: (_target, _thisArg, args): ServiceRequest => {
-        return { invoke: createInvoke(item), item, save: saveRequest }
+        return { invoke: createInvoke(item), item }
       }
     })
     return [item.name, proxy]
@@ -66,20 +54,18 @@ const createServiceRequests = ({ api, _id, item, save }: any) => {
 export const createServices = (api: ClientBuilder) => {
   return async (_id: string) => {
     const item = await api.services[_id].get()
-    const save = (data: ItemService) => api.services[_id].patch<ItemService>(data)
     const client = getClient(item)
 
     const requests = Object.fromEntries(
-      item.requests.map(createServiceRequests({ api, _id, item, save }))
+      item.requests.map(createServiceRequests({ api, _id, item }))
     )
 
-    return { client, requests, item, save } // see NOTE bellow
+    return { client, requests, item } // see NOTE bellow
   }
 }
 
 // NOTE: cannot return client directly like "return client"
 // nor use spread operator like "return { ...client, {...})" nor
 // "return Object.assign(client, {...})" somehow since client is
 // a Proxy object so we return a new object, which also extension
-// and prevents naming conflicts between metadata (e.g. item),
-// the client instance and eventual utilitiess (e.g. save)
+// and prevents naming conflicts between other props and methods

Diff for: src/services/types.ts

@@ -4,13 +4,11 @@ export interface Service {
   client: Client;
   requests: ServiceRequest[];
   item: ItemService;
-  save: (data: ItemService) => Promise<ItemService>;
 }
 
 export interface ServiceRequest {
   invoke: () => Promise<any>;
   item: ItemServiceRequest;
-  save: (data: ItemServiceRequest) => Promise<ItemServiceRequest>;
 }
 
 export interface ItemService {