Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting wrappers: Body-vector orientation #402

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

stellaprins
Copy link
Contributor

@stellaprins stellaprins commented Feb 4, 2025

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
To conveniently plot the vector between or midpoints between two keypoints (e.g. left_ear and right_ear for head trajectory, see third plot in computes polar coordinates example) with a single line of code.

What does this PR do?

References

#389

How has this PR been tested?

Checked the updated documentation locally.
Added tests that check whether the extracted vector ("quiver") U and V coordinates match the expected U V coordinates.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

computes polar coordinates example) has been updated.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@stellaprins stellaprins linked an issue Feb 4, 2025 that may be closed by this pull request
@stellaprins stellaprins changed the title Sp/389 plotting wrappers body vector orientation Plotting wrappers: Body-vector orientation Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.82%. Comparing base (84b245c) to head (d112aa2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
+ Coverage   99.80%   99.82%   +0.01%     
==========================================
  Files          15       20       +5     
  Lines        1048     1150     +102     
==========================================
+ Hits         1046     1148     +102     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Feb 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plotting wrappers: Body-vector orientation
1 participant