From 77d7e5c9cc09e4fe75d629f83bad9b8fc1a1eb58 Mon Sep 17 00:00:00 2001 From: Marty T <120425148+tippmar-nr@users.noreply.github.com> Date: Wed, 3 Jan 2024 17:02:54 -0600 Subject: [PATCH] test: Fix flicker in SpanStreamingServiceTests (#2167) --- .../Core.UnitTest/Spans/SpanStreamingServiceTests.cs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/Agent/UnitTests/Core.UnitTest/Spans/SpanStreamingServiceTests.cs b/tests/Agent/UnitTests/Core.UnitTest/Spans/SpanStreamingServiceTests.cs index 7d0aa13559..52276f0e32 100644 --- a/tests/Agent/UnitTests/Core.UnitTest/Spans/SpanStreamingServiceTests.cs +++ b/tests/Agent/UnitTests/Core.UnitTest/Spans/SpanStreamingServiceTests.cs @@ -650,13 +650,13 @@ public void DelayCallingRecordSpanAfterAnErrorStreamingASpan() } [Test] - public void MultpleConsumersItemsSentOnlyOnce() + public void MultipleConsumersItemsSentOnlyOnce() { Mock.Arrange(() => _currentConfiguration.InfiniteTracingBatchSizeSpans).Returns(4); Mock.Arrange(() => _currentConfiguration.InfiniteTracingTraceCountConsumers).Returns(3); _streamingSvc = GetService(_delayer, _grpcWrapper, _configSvc, _agentHealthReporter); - var actualItems = new List(); + var actualItems = new ConcurrentBag(); var requestItems = new ConcurrentBag(); for (var i = 0; i < 100; i++) { @@ -668,7 +668,8 @@ public void MultpleConsumersItemsSentOnlyOnce() _grpcWrapper.WithTrySendDataImpl = (stream, requestBatch, timeout, token) => { var requests = GetBatchItems(requestBatch); - actualItems.AddRange(requests); + foreach (var streamingModel in requests) + actualItems.Add(streamingModel); return true; };