予約のかかっている資料に新規の所蔵を作成できないのを修正 (#1967)

nabeta · web-flow · commit c740b44fe29d · 2025-06-22T14:28:06.000+09:00
* fix creating item for reserved manifestation

* fix spec file

* fix spec file

* fix spec file

* fix spec file
diff --git a/app/controllers/items_controller.rb b/app/controllers/items_controller.rb
@@ -193,11 +193,10 @@ def edit
   # POST /items.json
   def create
     @item = Item.new(item_params)
-    manifestation = Manifestation.find(@item.manifestation_id)
+    @item.manifestation = Manifestation.find(@item.manifestation_id)
 
     respond_to do |format|
       if @item.save
-        @item.manifestation = manifestation
         Item.transaction do
           if defined?(EnjuCirculation)
             if @item.reserved?
diff --git a/spec/controllers/items_controller_spec.rb b/spec/controllers/items_controller_spec.rb
@@ -333,6 +333,12 @@ def valid_attributes
         expect(assigns(:item)).to_not be_valid
         expect(response).to be_successful
       end
+
+      it 'should create item already reserved' do
+        post :create, params: { item: @attrs.merge(manifestation_id: 11) }
+        expect(assigns(:item)).to be_valid
+        expect(response).to redirect_to(item_url(assigns(:item)))
+      end
     end
 
     describe 'When logged in as Librarian' do
