Skip to content

Commit 4cb893a

Browse files
committed
feature(3331): card image refactor
Signed-off-by: Luutzen Dijkstra <[email protected]>
1 parent ff611b1 commit 4cb893a

File tree

3 files changed

+5
-13
lines changed

3 files changed

+5
-13
lines changed

src/components/cards/CardCover.vue

+3-12
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,10 @@
44
-->
55

66
<template>
7-
<div v-if="referencePreview" class="card-cover">
8-
<div class="image-wrapper rounded-left rounded-right" :style="{ backgroundImage: `url(${referencePreview})`}" />
9-
</div>
10-
<div v-else-if="cardId && ( attachments.length > 0 )" class="card-cover">
11-
<div v-for="(attachment, index) in attachments"
7+
<div v-if="cardId && ( attachments.length > 0 )" class="card-cover">
8+
<div v-for="attachment in attachments"
129
:key="attachment.id"
13-
:class="['image-wrapper', { 'rounded-left': index === 0 }, { 'rounded-right': index === attachments.length - 1 }]"
10+
class="image-wrapper"
1411
:style="{ backgroundImage: `url(${attachmentPreview(attachment)})` }" />
1512
</div>
1613
</template>
@@ -85,12 +82,6 @@ export default {
8582
background-size: cover;
8683
background-repeat: no-repeat;
8784
background-position: center center;
88-
&.rounded-left {
89-
border-top-left-radius: calc(var(--border-radius-large) - 1px);
90-
}
91-
&.rounded-right {
92-
border-top-right-radius: calc(var(--border-radius-large) - 1px);
93-
}
9485
}
9586
}
9687
</style>

src/components/cards/CardItem.vue

+1
Original file line numberDiff line numberDiff line change
@@ -337,6 +337,7 @@ export default {
337337
display: flex;
338338
flex-direction: column;
339339
gap: $card-gap;
340+
overflow: hidden;
340341

341342
&:deep(*) {
342343
cursor: pointer;

src/css/variables.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66
$card-max-width: 300px;
77
$card-padding: calc(var(--default-grid-baseline) * 2) calc(var(--default-grid-baseline) * 2) var(--default-grid-baseline);
88
$card-gap: calc(var(--default-grid-baseline) * 3);
9-
$card-image-margin: calc(var(--default-grid-baseline) * -1);
9+
$card-image-margin: calc(var(--default-grid-baseline) * -2);
1010
$stack-gap: calc(var(--default-grid-baseline) * 3);
1111
$board-gap: calc(var(--default-grid-baseline) * 4);

0 commit comments

Comments
 (0)