Skip to content

Commit 96f9258

Browse files
marcoambrosiniSebastianKrupinski
authored andcommitted
Add clickable area info
Signed-off-by: Marco <[email protected]>
1 parent 8344c82 commit 96f9258

File tree

1 file changed

+20
-0
lines changed

1 file changed

+20
-0
lines changed

developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.rst

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,26 @@ Capabilities
3131
Front-end changes
3232
-----------------
3333

34+
Clickable area
35+
^^^^^^^^^^^^^^
36+
The size of the CSS variable ``--clickable-area`` variable has shrunk from ``44px`` to ``34px``.
37+
This will result in several regressions and paper-cuts in your app that will need to be manually fixed.
38+
It's recommended to:
39+
40+
1) Link the @nextcloud/vue current master to your app (pull often cause fixes are getting in there too);
41+
2) Do a codebase-wide search of `44px` and replace with the variable `--default-clickable-area` if appropriate;
42+
3) Check for regressions and visual bugs;
43+
4) Report the regression of your app in this issue (you can create a heading with the name of your own app);
44+
5) Also report @nextlcoud/vue library regressions if they're not reported already in their list;
45+
6) Fix regression in your app (only the ones that are unrelated to the @nextcloud/vue components);
46+
47+
Line height
48+
^^^^^^^^^^^
49+
The ``--default-line-height`` variable has changed from ``24px``` to ``1.5`` for the ``--default-font-size`` this
50+
means that the actual value in pixel will go from 24 to 22.5. Although this is a slight change, it's recommended
51+
to check for visual regressions in your app.
52+
53+
3454
Font sizes
3555
^^^^^^^^^^
3656

0 commit comments

Comments
 (0)