adjustemens and cleanup to current codebase

Signed-off-by: Arthur Schiwon <[email protected]>

Author: blizzz

lib/AppInfo/Application.php

@@ -16,12 +16,6 @@
 use OCP\AppFramework\Bootstrap\IRegistrationContext;
 
 class Application extends App implements IBootstrap {
-	/** @var LDAPUserManager */
-	protected $ldapUserManager;
-
-	/** @var LDAPGroupManager */
-	protected $ldapGroupManager;
-
 	public const APP_ID = 'ldap_write_support';
 
 	public function __construct(array $urlParams = []) {
@@ -34,10 +28,5 @@ public function register(IRegistrationContext $context): void {
 	}
 
 	public function boot(IBootContext $context): void {
-			$s->getUserSession(),
-			$provider,
-			$c->query(Configuration::class),
-			$s->getL10N(self::APP_ID),
-			$s->getLogger()
 	}
 }

lib/LDAPGroupManager.php

@@ -31,8 +31,6 @@
 use OCA\LdapWriteSupport\Service\Configuration;
 use OCA\User_LDAP\Group_Proxy;
 use OCA\User_LDAP\ILDAPGroupPlugin;
-use OCA\User_LDAP\LDAPProvider;
-use OCP\AppFramework\QueryException;
 use OCP\IGroupManager;
 use OCP\IL10N;
 use OCP\ILogger;
@@ -41,6 +39,8 @@
 use OCP\LDAP\ILDAPProvider;
 
 class LDAPGroupManager implements ILDAPGroupPlugin {
+	/** @var Configuration */
+	protected $configuration;
 
 	/** @var ILDAPProvider */
 	private $ldapProvider;
@@ -175,7 +175,6 @@ public function addToGroup($uid, $gid) {
 				break;
 			case 'gidNumber':
 				throw new Exception('Cannot add to group when gidNumber is used as relation');
-				break;
 		}
 
 		if (!$ret = ldap_mod_add($connection, $groupDN, $entry)) {
@@ -215,7 +214,6 @@ public function removeFromGroup($uid, $gid) {
 				break;
 			case 'gidNumber':
 				throw new Exception('Cannot remove from group when gidNumber is used as relation');
-				break;
 		}
 
 		if (!$ret = ldap_mod_del($connection, $groupDN, $entry)) {