-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow sync of .htaccess files #13831
Comments
Apparently the
Would it make sense to programatically remove the filter when the While having a filter for |
To sync .htaccess files, add to server file /config/config.php next line: |
See above. But I'm pretty sure that's a bad idea, we don't officially recommend doing this whatsoever! |
@skjnldsv I am not entirely sure why this ticket was closed.
My understanding is, that there is a hack to get these files synced, yet this hack is neither recommended, nor tested. Does this mean that the bug is indeed existing and it won’t be fixed? Having a system that syncs files just ignore some files due to the underlying implementation details does not seem acceptable. Could you just quickly comment on your reasoning? |
Allowing uploading of such files could will put them into the data folder. If anyone want to open a pr for this it will be reviewed by Nextcloud as well as our security team. Until them, I'm cleaning tickets :) |
@skjnldsv Thank you for clearing things up. Say I would want to try my luck at a potential PR, would you have any pointers as how to go about solving this issue? The first idea that comes to mind would be to prefix file names in the This seems hacky and certainly not worthy of being merged. |
I consider this feature essential for web development! (and hosting my personal wiki, DokuWiki)
I think this solution is acceptable! A 'blacklisted name files' folder could be created on the server (with files renamed), and recovered in client requests (simply download the blacklisted file and rename on the client). The same when saving files. This certainly removes any security concerns. If the security concern is fixed in the future (hopefully without requiring specific server configuration), then it could be fixed another way, but I'm not sure this will ever be true. |
I suggest this solution: This allows the user to upload .htaccess files without being treated by the webserver in any special way. |
Thx, that's the idea I needed. |
@michaelberg79 , glad my comment was noticed by someone at last. |
@skjnldsv , would you please take a look at my proposed solution? Hopefully you would reopen this ticket, if you find it doable. |
I find the characterisation of this as a 'super edge case' quite surprising. |
Is your feature request related to a problem? Please describe.
It's not possible to synchronize
.htaccess
files. Even when not specifying its name in the config blacklisted_files.Describe the solution you'd like
.htaccess
should be syncable. Perhaps only if data is not in web server root or if web server if nginx. And, at least, provide an option to deactivate this protection (.htaccess
are important for web developers). Perhaps some kind of magic rename should occur on the server side for this specific case (renaming.htaccess
to.htaccess\011\011
for example), magic reversed when syncing to the client.Describe alternatives you've considered
Renaming the file. Quite impractical.
The text was updated successfully, but these errors were encountered: