Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite verifyIntegrity() to work with less memory #598

Open
Smoerrebroed opened this issue Jan 22, 2025 · 0 comments
Open

Rewrite verifyIntegrity() to work with less memory #598

Smoerrebroed opened this issue Jan 22, 2025 · 0 comments

Comments

@Smoerrebroed
Copy link

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Feature request

Which Nextcloud Version are you currently using: (see administration page)
30.0.4

Is your feature request related to a problem? Please describe.
Yes. With < 256 M memory limit, verifyIntegrity() seems to fail silently with the current version.

Describe the solution you'd like
Make verifyIntegrity() less dependent on available memory. Right now, if the downloaded .zip file does not fit within the constraints of memory, it seems to silently fail which really throws off users without too much technical background. There is no mention of the root cause for the termination.

Describe alternatives you've considered
An alternative could be either skipping verification if the archive is too large (and alerting the user) or at least providing a config option to skip this verification.

Additional context
In some environments, it is not easily possible to increase the memory limit. Also, it is really hard to find out the root cause for this strange behaviour without any hint what is going (which is the current state of affairs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant