filter: Error when any group-by column is not found #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorlin
force-pushed
the
filter/error-on-group-by-not-found
branch
from
eef7767 to
c8489dc
Compare
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
==========================================
+ Coverage 34.58% 34.61% +0.03%
==========================================
Files 42 42
Lines 6055 6040 -15
Branches 1551 1549 -2
==========================================
- Hits 2094 2091 -3
+ Misses 3887 3875 -12
Partials 74 74
Continue to review full report at Codecov.
|
victorlin
added
the
breaking
Actualizing the TODO removed in this change: > TODO: We should consider treating this case as an actual error and exiting here with a nonzero code. With 2342f07, raising FilterException(AugurError) alone is sufficient to exit with a nonzero code. Also updated error text to remove message "No sequences-per-group sampling will be done", which was part of a warning. Implicitly, nothing will be done when exiting with an ERROR.
victorlin
force-pushed
the
filter/error-on-group-by-not-found
branch
from
c8489dc to
7cac045
Compare
huddlej
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Actualizing the TODO removed in this change:
With 2342f07, raising
FilterException(AugurError)alone is sufficient to exit with a nonzero code.Also updated error text to remove message "No sequences-per-group sampling will be done", which was part of a warning. Implicitly, nothing will be done when exiting with an ERROR.
Related issue(s)
KeyError: ('_dummy',)#932Testing
Added cram tests.