Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflicting manifest csv (different keys) cause app to crash #58

Open
allaway opened this issue Feb 19, 2021 · 0 comments
Open

conflicting manifest csv (different keys) cause app to crash #58

allaway opened this issue Feb 19, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@allaway
Copy link

allaway commented Feb 19, 2021

Describe the bug
When a manifest csv (synapse_storage_manifest.csv) is created by the app, if it another is created by the app with a different manifest type (with different columns), it throws an error that causes the app to crash IF the manifest csv is being written to the same synapse folder. Likely caused by some joining issue or missing column issue between the old and new versions when schematic reconciles the two.

To Reproduce
Steps to reproduce the behavior:
Upload a manifest of annotations using the app to a directory.
Upload a different manifest of annotations using a different schema that has at least one column that manifest a did not have, to the same directory.

Expected behavior
Expect something different, but not this. Maybe an error, but not app crash.

A simple solution here is to not upload manifest csvs as we do not use them. I think that this is something that will not happen that often if we push our users to organize by data type when possible, but I could see us running into issues if manifests change over time.

The easy fix when this happens is to delete the offending synapse_storage_manifest.csv that is on synapse in the directory that you are trying to upload (or, if for some reason it needs to be retained, rename it to something else).

This is a low priority issue, I'm primarily documenting it here so we can resolve it if we run into it again.

@allaway allaway added the bug Something isn't working label Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant