Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRIDE] Check existence of content for required columns #68

Open
HLWeil opened this issue Nov 19, 2024 · 1 comment · May be fixed by #72
Open

[PRIDE] Check existence of content for required columns #68

HLWeil opened this issue Nov 19, 2024 · 1 comment · May be fixed by #72
Assignees

Comments

@HLWeil
Copy link
Member

HLWeil commented Nov 19, 2024

Currently, only the headers of e.g. Variable Modification are checked. The test still passes if only the header is given but the column is left empty.

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Nov 19, 2024
@omaus omaus self-assigned this Nov 19, 2024
@omaus
Copy link
Collaborator

omaus commented Nov 19, 2024

I see the problem here. I didn't check for terms as values here (since custom modifications should be allowed too) but forget to check for non-emptiness.

@omaus omaus moved this to In progress in ARCStack Nov 20, 2024
@omaus omaus removed the Status: Needs Triage This item is up for investigation. label Feb 11, 2025
@omaus omaus moved this from In progress to In review in ARCStack Feb 11, 2025
@omaus omaus linked a pull request Feb 12, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging a pull request may close this issue.

2 participants