Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture access token from IdP #54

Closed
shawnhankim opened this issue Nov 9, 2022 · 2 comments
Closed

Capture access token from IdP #54

shawnhankim opened this issue Nov 9, 2022 · 2 comments

Comments

@shawnhankim
Copy link
Contributor

Background:

  • Current NJS implementation disregard the access_token that is being sent by the IdP and only uses the id_token to get stored in the NGINX Plus K/V store.

  • Token Recommandation

    When Using Do Don't
    ID Token - Assume the user is authenticated - Call an API
    - Get user profile data - Check if the client is allowed to access something.
    Access Token - Call an API - Inspect its content on the client
    - Check if the client is allowed to access something
    - Inspect its content on the server side

    courtesy: ID Token and Access Token: What's the Difference?

Acceptance Criteria:

  • Enhance the NJS Code to capture the access_token sent by the IdP.
  • Store the access_token in the k/v store as same as we store id_token and refresh_token

Compatibility:

  • This issue will not block the existing features as there would be no change of variables, and this is just to add features.
@shawnhankim shawnhankim changed the title feat: capture access token from IdP Capture access token from IdP Nov 9, 2022
@shawnhankim
Copy link
Contributor Author

@route443 : You can use this PR if you want to test the access token.

@shawnhankim
Copy link
Contributor Author

Per discussion with @route443 : I close this PR because I have consolidated this PR into #55. Thanks @route443 for your time. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant