Fix configuration order in tests (#3557)

Author: hazzik

src/NHibernate.Test/Async/BulkManipulation/NativeSQLBulkOperationsWithCache.cs

@@ -33,9 +33,9 @@ public class NativeSQLBulkOperationsWithCacheAsync : TestCase
 
 		protected override void Configure(Configuration configuration)
 		{
-			cfg.SetProperty(Environment.UseQueryCache, "true");
-			cfg.SetProperty(Environment.UseSecondLevelCache, "true");
-			cfg.SetProperty(Environment.CacheProvider, typeof(SubstituteCacheProvider).AssemblyQualifiedName);
+			configuration.SetProperty(Environment.UseQueryCache, "true");
+			configuration.SetProperty(Environment.UseSecondLevelCache, "true");
+			configuration.SetProperty(Environment.CacheProvider, typeof(SubstituteCacheProvider).AssemblyQualifiedName);
 		}
 
 		[Test]

src/NHibernate.Test/Async/Cascade/Circle/MultiPathCircleCascadeTest.cs

@@ -54,7 +54,6 @@ protected override string[] Mappings
 
 		protected override void Configure(NHibernate.Cfg.Configuration configuration)
 		{
-			base.Configure(configuration);
 			configuration.SetProperty(NHibernate.Cfg.Environment.GenerateStatistics, "true");
 			configuration.SetProperty(NHibernate.Cfg.Environment.BatchSize, "0");
 		}

src/NHibernate.Test/Async/ConnectionTest/AggressiveReleaseTest.cs

@@ -24,13 +24,12 @@ namespace NHibernate.Test.ConnectionTest
 	[TestFixture]
 	public class AggressiveReleaseTestAsync : ConnectionManagementTestCase
 	{
-		protected override void Configure(Configuration cfg)
+		protected override void Configure(Configuration configuration)
 		{
-			base.Configure(cfg);
-			cfg.SetProperty(Environment.ReleaseConnections, "after_transaction");
-			//cfg.SetProperty(Environment.ConnectionProvider, typeof(DummyConnectionProvider).AssemblyQualifiedName);
-			//cfg.SetProperty(Environment.GenerateStatistics, "true");
-			cfg.SetProperty(Environment.BatchSize, "0");
+			configuration.SetProperty(Environment.ReleaseConnections, "after_transaction");
+			//configuration.SetProperty(Environment.ConnectionProvider, typeof(DummyConnectionProvider).AssemblyQualifiedName);
+			//configuration.SetProperty(Environment.GenerateStatistics, "true");
+			configuration.SetProperty(Environment.BatchSize, "0");
 		}
 
 		protected override ISession GetSessionUnderTest()

src/NHibernate.Test/Async/ConnectionTest/BatcherFixture.cs

@@ -22,10 +22,9 @@ namespace NHibernate.Test.ConnectionTest
 	[TestFixture]
 	public class BatcherFixtureAsync : ConnectionManagementTestCase
 	{
-		protected override void Configure(Configuration config)
+		protected override void Configure(Configuration configuration)
 		{
-			base.Configure(config);
-			config.SetProperty(Environment.BatchSize, "10");
+			configuration.SetProperty(Environment.BatchSize, "10");
 		}
 
 		protected override ISession GetSessionUnderTest()
@@ -53,4 +52,4 @@ public async Task CanCloseCommandsAndUseBatcherAsync()
 			}
 		}
 	}
-}
+}

src/NHibernate.Test/Async/Criteria/ReadonlyTests/QueryOverCacheableTests.cs

@@ -27,7 +27,6 @@ protected override void Configure(Configuration config)
 		{
 			config.SetProperty(Environment.UseQueryCache, "true");
 			config.SetProperty(Environment.GenerateStatistics, "true");
-			base.Configure(config);
 		}
 
 		[Test]

src/NHibernate.Test/Async/FetchLazyProperties/FetchLazyPropertiesFixture.cs

@@ -44,7 +44,6 @@ protected override bool AppliesTo(Dialect.Dialect dialect)
 
 		protected override void Configure(Configuration configuration)
 		{
-			base.Configure(configuration);
 			configuration.Properties[Environment.CacheProvider] = typeof(HashtableCacheProvider).AssemblyQualifiedName;
 			configuration.Properties[Environment.UseSecondLevelCache] = "true";
 		}

src/NHibernate.Test/Async/Futures/FallbackFixture.cs

@@ -43,8 +43,7 @@ protected override bool AppliesTo(Dialect.Dialect dialect)
 
 		protected override void Configure(Configuration configuration)
 		{
-			base.Configure(configuration);
-			using (var cp = ConnectionProviderFactory.NewConnectionProvider(cfg.Properties))
+			using (var cp = ConnectionProviderFactory.NewConnectionProvider(configuration.Properties))
 			{
 				if (cp.Driver is SqlClientDriver)
 				{

src/NHibernate.Test/Async/Generatedkeys/Identity/IdentityGeneratedKeysTest.cs

@@ -36,7 +36,6 @@ protected override bool AppliesTo(Dialect.Dialect dialect)
 
 		protected override void Configure(Configuration configuration)
 		{
-			base.Configure(configuration);
 			configuration.SetProperty(Environment.GenerateStatistics, "true");
 		}
 

src/NHibernate.Test/Async/Immutable/ImmutableTest.cs

@@ -29,7 +29,6 @@ public class ImmutableTestAsync : TestCase
 	{
 		protected override void Configure(Configuration configuration)
 		{
-			base.Configure(configuration);
 			configuration.SetProperty(NHibernate.Cfg.Environment.GenerateStatistics, "true");
 			configuration.SetProperty(NHibernate.Cfg.Environment.BatchSize, "0");
 		}

src/NHibernate.Test/Async/LazyGroup/LazyGroupFixture.cs

@@ -30,7 +30,6 @@ public class LazyGroupFixtureAsync : TestCase
 
 		protected override void Configure(Configuration configuration)
 		{
-			base.Configure(configuration);
 			configuration.Properties[Environment.CacheProvider] = typeof(HashtableCacheProvider).AssemblyQualifiedName;
 			configuration.Properties[Environment.UseSecondLevelCache] = "true";
 			configuration.Properties[Environment.GenerateStatistics] = "true";