Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after timeout, the whole run fails without another attempt #114

Open
gingerlime opened this issue Jun 14, 2023 · 1 comment
Open

after timeout, the whole run fails without another attempt #114

gingerlime opened this issue Jun 14, 2023 · 1 comment
Assignees

Comments

@gingerlime
Copy link

Describe the bug
after timeout, the whole run fails without another attempt

Expected behavior
as far as I can tell from the documentation, the timeout applies to each retry, so if it times-out on the first time, it will retry again etc

Screenshots

      - name: run bats tests
        uses: nick-fields/retry@v2
        with:
          timeout_minutes: 2
          max_attempts: 3
          command: |
            docker image ls -a
            for filename in tests/*.bats; do sudo bats --tap "$filename" || exit 1; done
/home/runner/work/_actions/nick-fields/retry/v2/dist/index.js:3199
            throw err;
            ^

Error: kill EPERM
    at process.kill (node:internal/process/per_thread:220:13)
    at killPid (/home/runner/work/_actions/nick-fields/retry/v2/dist/index.js:3209:17)
    at /home/runner/work/_actions/nick-fields/retry/v2/dist/index.js:3186:21
    at Array.forEach (<anonymous>)
    at /home/runner/work/_actions/nick-fields/retry/v2/dist/index.js:3184:23
    at Array.forEach (<anonymous>)
    at killAll (/home/runner/work/_actions/nick-fields/retry/v2/dist/index.js:3183:27)
    at /home/runner/work/_actions/nick-fields/retry/v2/dist/index.js:3174:13
    at ChildProcess.onClose (/home/runner/work/_actions/nick-fields/retry/v2/dist/index.js:3230:17)
    at ChildProcess.emit (node:events:527:28) {
  errno: -1,
  code: 'EPERM',
  syscall: 'kill'
}

Logs
run

raw log with debug

@gustavotrott
Copy link

same thing here

image

My code:

https://github.com/bigbluebutton/bigbluebutton/blob/2b9870bea815d8aade79d088d966e5b804b377bf/.github/workflows/automated-tests.yml#L259

kirillzyusko added a commit to kirillzyusko/react-native-keyboard-controller that referenced this issue Nov 15, 2024
## 📜 Description

Fixed an issue when additional runtime installation can not be
terminated after 10 minutes.

## 💡 Motivation and Context

When using [nick-fields/retry](https://github.com/nick-fields/retry) and
we interrupt sudo command then we are getting errors like this
nick-fields/retry#114 or
nick-fields/retry#124

To overcome this problem I decided to create own script for retrying a
command. This PR delivers that.

## 📢 Changelog

<!-- High level overview of important changes -->
<!-- For example: fixed status bar manipulation; added new types
declarations; -->
<!-- If your changes don't affect one of platform/language below - then
remove this platform/language -->

### CI

- replace `nick-fields/retry` with own action;

## 🤔 How Has This Been Tested?

Reduced timeout to 2 minutes and verified that action was repeated 3
times with 1 minute delay between attempts.

## 📸 Screenshots (if appropriate):

<img width="1312" alt="image"
src="https://github.com/user-attachments/assets/051aea2e-32d1-4878-bf8f-b6831948c7c2">

## 📝 Checklist

- [x] CI successfully passed
- [x] I added new mocks and corresponding unit-tests if library API was
changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants