Skip to content

Commit 9369048

Browse files
committed
refact filter_timeout_by_rtype name
1 parent 7220311 commit 9369048

File tree

2 files changed

+27
-27
lines changed

2 files changed

+27
-27
lines changed

src/dns_cache.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ impl DnsCache {
176176
/// If it has expired, it removes it from the cache.
177177
pub fn timeout_cache(&mut self) {
178178
let mut cache = self.get_cache();
179-
cache.filter_timeout_cache_data();
179+
cache.filter_timeout_by_rtype();
180180
self.set_cache(cache);
181181
}
182182
}

src/dns_cache/cache_by_record_type.rs

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -163,16 +163,16 @@ impl CacheByRecordType{
163163
/// For each type of cache data, it removes the cache data that has expired, using
164164
/// the `timeout_rr_cache` method of the `CacheByDomainName` struct. If the `CacheByDomainName` struct
165165
/// is empty after the removal, it is removed from the cache data.
166-
pub fn filter_timeout_cache_data(&mut self) {
166+
pub fn filter_timeout_by_rtype(&mut self) {
167167
let cache_data = self.get_cache_data();
168168
let clean_cache_data: HashMap<Rtype, CacheByDomainName> = cache_data
169169
.into_iter()
170-
.filter_map(|(rtype, mut host_data)| {
171-
host_data.filter_timeout_by_domain_name();
172-
if host_data.get_domain_names_data().is_empty() {
170+
.filter_map(|(rtype, mut data_by_domain)| {
171+
data_by_domain.filter_timeout_by_domain_name();
172+
if data_by_domain.get_domain_names_data().is_empty() {
173173
None
174174
} else {
175-
Some((rtype, host_data))
175+
Some((rtype, data_by_domain))
176176
}
177177
})
178178
.collect();
@@ -447,7 +447,7 @@ mod cache_data_test{
447447
}
448448

449449
#[test]
450-
fn filter_timeout_cache_data_rtype_a() {
450+
fn filter_timeout_by_rtype_rtype_a() {
451451
use std::{thread, time};
452452
let mut cache_record_type = CacheByRecordType::new();
453453
let a_rdata = Rdata::A(ARdata::new());
@@ -474,7 +474,7 @@ mod cache_data_test{
474474
println!("Before timeout: {:?}", Utc::now());
475475
thread::sleep(time::Duration::from_secs(5));
476476
println!("After timeout: {:?}", Utc::now());
477-
cache_record_type.filter_timeout_cache_data();
477+
cache_record_type.filter_timeout_by_rtype();
478478

479479
//check if the len is 1 instead of 2 (one RRStoredData was eliminated)
480480
if let Some(rr_cache_vec) = cache_record_type.get_from_cache_data(domain_name.clone(), Rtype::A){
@@ -489,7 +489,7 @@ mod cache_data_test{
489489
}
490490

491491
#[test]
492-
fn filter_timeout_cache_data_rtype_ns() {
492+
fn filter_timeout_by_rtype_rtype_ns() {
493493
use std::{thread, time};
494494
let mut cache_record_type = CacheByRecordType::new();
495495
let ns_rdata = Rdata::NS(NsRdata::new());
@@ -516,7 +516,7 @@ mod cache_data_test{
516516
println!("Before timeout: {:?}", Utc::now());
517517
thread::sleep(time::Duration::from_secs(5));
518518
println!("After timeout: {:?}", Utc::now());
519-
cache_record_type.filter_timeout_cache_data();
519+
cache_record_type.filter_timeout_by_rtype();
520520

521521
//check if the len is 1 instead of 2 (one RRStoredData was eliminated)
522522
if let Some(rr_cache_vec) = cache_record_type.get_from_cache_data(domain_name.clone(), Rtype::NS){
@@ -531,7 +531,7 @@ mod cache_data_test{
531531
}
532532

533533
#[test]
534-
fn filter_timeout_cache_data_rtype_cname() {
534+
fn filter_timeout_by_rtype_rtype_cname() {
535535
use std::{thread, time};
536536
let mut cache_record_type = CacheByRecordType::new();
537537
let cname_rdata = Rdata::CNAME(CnameRdata::new());
@@ -558,7 +558,7 @@ mod cache_data_test{
558558
println!("Before timeout: {:?}", Utc::now());
559559
thread::sleep(time::Duration::from_secs(5));
560560
println!("After timeout: {:?}", Utc::now());
561-
cache_record_type.filter_timeout_cache_data();
561+
cache_record_type.filter_timeout_by_rtype();
562562

563563
//check if the len is 1 instead of 2 (one RRStoredData was eliminated)
564564
if let Some(rr_cache_vec) = cache_record_type.get_from_cache_data(domain_name.clone(), Rtype::CNAME){
@@ -573,7 +573,7 @@ mod cache_data_test{
573573
}
574574

575575
#[test]
576-
fn filter_timeout_cache_data_rtype_soa() {
576+
fn filter_timeout_by_rtype_rtype_soa() {
577577
use std::{thread, time};
578578
let mut cache_record_type = CacheByRecordType::new();
579579
let soa_rdata = Rdata::SOA(SoaRdata::new());
@@ -600,7 +600,7 @@ mod cache_data_test{
600600
println!("Before timeout: {:?}", Utc::now());
601601
thread::sleep(time::Duration::from_secs(5));
602602
println!("After timeout: {:?}", Utc::now());
603-
cache_record_type.filter_timeout_cache_data();
603+
cache_record_type.filter_timeout_by_rtype();
604604

605605
//check if the len is 1 instead of 2 (one RRStoredData was eliminated)
606606
if let Some(rr_cache_vec) = cache_record_type.get_from_cache_data(domain_name.clone(), Rtype::SOA){
@@ -615,7 +615,7 @@ mod cache_data_test{
615615
}
616616

617617
#[test]
618-
fn filter_timeout_cache_data_rtype_ptr() {
618+
fn filter_timeout_by_rtype_rtype_ptr() {
619619
use std::{thread, time};
620620
let mut cache_record_type = CacheByRecordType::new();
621621
let ptr_rdata = Rdata::PTR(PtrRdata::new());
@@ -642,7 +642,7 @@ mod cache_data_test{
642642
println!("Before timeout: {:?}", Utc::now());
643643
thread::sleep(time::Duration::from_secs(5));
644644
println!("After timeout: {:?}", Utc::now());
645-
cache_record_type.filter_timeout_cache_data();
645+
cache_record_type.filter_timeout_by_rtype();
646646

647647
//check if the len is 1 instead of 2 (one RRStoredData was eliminated)
648648
if let Some(rr_cache_vec) = cache_record_type.get_from_cache_data(domain_name.clone(), Rtype::PTR){
@@ -657,7 +657,7 @@ mod cache_data_test{
657657
}
658658

659659
#[test]
660-
fn filter_timeout_cache_data_rtype_mx() {
660+
fn filter_timeout_by_rtype_rtype_mx() {
661661
use std::{thread, time};
662662
let mut cache_record_type = CacheByRecordType::new();
663663
let mx_rdata = Rdata::MX(MxRdata::new());
@@ -684,7 +684,7 @@ mod cache_data_test{
684684
println!("Before timeout: {:?}", Utc::now());
685685
thread::sleep(time::Duration::from_secs(5));
686686
println!("After timeout: {:?}", Utc::now());
687-
cache_record_type.filter_timeout_cache_data();
687+
cache_record_type.filter_timeout_by_rtype();
688688

689689
//check if the len is 1 instead of 2 (one RRStoredData was eliminated)
690690
if let Some(rr_cache_vec) = cache_record_type.get_from_cache_data(domain_name.clone(), Rtype::MX){
@@ -699,7 +699,7 @@ mod cache_data_test{
699699
}
700700

701701
#[test]
702-
fn filter_timeout_cache_data_rtype_txt() {
702+
fn filter_timeout_by_rtype_rtype_txt() {
703703
use std::{thread, time};
704704
let mut cache_record_type = CacheByRecordType::new();
705705
let txt_rdata = Rdata::TXT(TxtRdata::new(vec![String::from("test")]));
@@ -726,7 +726,7 @@ mod cache_data_test{
726726
println!("Before timeout: {:?}", Utc::now());
727727
thread::sleep(time::Duration::from_secs(5));
728728
println!("After timeout: {:?}", Utc::now());
729-
cache_record_type.filter_timeout_cache_data();
729+
cache_record_type.filter_timeout_by_rtype();
730730

731731
//check if the len is 1 instead of 2 (one RRStoredData was eliminated)
732732
if let Some(rr_cache_vec) = cache_record_type.get_from_cache_data(domain_name.clone(), Rtype::TXT){
@@ -741,7 +741,7 @@ mod cache_data_test{
741741
}
742742

743743
#[test]
744-
fn filter_timeout_cache_data_rtype_hinfo() {
744+
fn filter_timeout_by_rtype_rtype_hinfo() {
745745
use std::{thread, time};
746746
let mut cache_record_type = CacheByRecordType::new();
747747
let hinfo_rdata = Rdata::HINFO(HinfoRdata::new());
@@ -768,7 +768,7 @@ mod cache_data_test{
768768
println!("Before timeout: {:?}", Utc::now());
769769
thread::sleep(time::Duration::from_secs(5));
770770
println!("After timeout: {:?}", Utc::now());
771-
cache_record_type.filter_timeout_cache_data();
771+
cache_record_type.filter_timeout_by_rtype();
772772

773773
//check if the len is 1 instead of 2 (one RRStoredData was eliminated)
774774
if let Some(rr_cache_vec) = cache_record_type.get_from_cache_data(domain_name.clone(), Rtype::HINFO){
@@ -784,7 +784,7 @@ mod cache_data_test{
784784

785785

786786
#[test]
787-
fn filter_timeout_cache_data_rtype_tsig() {
787+
fn filter_timeout_by_rtype_rtype_tsig() {
788788
use std::{thread, time};
789789
let mut cache_record_type = CacheByRecordType::new();
790790
let tsig_rdata = Rdata::TSIG(TSigRdata::new());
@@ -811,7 +811,7 @@ mod cache_data_test{
811811
println!("Before timeout: {:?}", Utc::now());
812812
thread::sleep(time::Duration::from_secs(5));
813813
println!("After timeout: {:?}", Utc::now());
814-
cache_record_type.filter_timeout_cache_data();
814+
cache_record_type.filter_timeout_by_rtype();
815815

816816
//check if the len is 1 instead of 2 (one RRStoredData was eliminated)
817817
if let Some(rr_cache_vec) = cache_record_type.get_from_cache_data(domain_name.clone(), Rtype::TSIG){
@@ -864,7 +864,7 @@ mod cache_data_test{
864864
println!("Before timeout: {:?}", Utc::now());
865865
thread::sleep(time::Duration::from_secs(5));
866866
println!("After timeout: {:?}", Utc::now());
867-
cache_record_type.filter_timeout_cache_data();
867+
cache_record_type.filter_timeout_by_rtype();
868868

869869
let record_types_data_after_clean = cache_record_type.get_cache_data();
870870

@@ -927,7 +927,7 @@ mod cache_data_test{
927927
println!("Before timeout: {:?}", Utc::now());
928928
thread::sleep(time::Duration::from_secs(5));
929929
println!("After timeout: {:?}", Utc::now());
930-
cache_record_type.filter_timeout_cache_data();
930+
cache_record_type.filter_timeout_by_rtype();
931931

932932
let record_types_data_after_cleaning = cache_record_type.get_cache_data();
933933

@@ -1007,7 +1007,7 @@ mod cache_data_test{
10071007
println!("Before timeout: {:?}", Utc::now());
10081008
thread::sleep(time::Duration::from_secs(5));
10091009
println!("After timeout: {:?}", Utc::now());
1010-
cache_record_type.filter_timeout_cache_data();
1010+
cache_record_type.filter_timeout_by_rtype();
10111011

10121012
let record_types_data_after_cleaning = cache_record_type.get_cache_data();
10131013

0 commit comments

Comments
 (0)