Skip to content

Commit 0a6b800

Browse files
authored
Merge pull request #520 from nimblehq/feature/kmm-support-refactor-all-package-names
[#515] [KMM Support] Refactor package names (reopen)
2 parents 72a7df8 + 161f9e0 commit 0a6b800

File tree

42 files changed

+90
-92
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+90
-92
lines changed

template-compose/app/proguard-rules.pro

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,5 @@
2121
#-renamesourcefileattribute SourceFile
2222

2323
# Data class
24-
-keepclassmembers class co.nimblehq.template.compose.data.request.** { *; }
25-
-keepclassmembers class co.nimblehq.template.compose.data.response.** { *; }
24+
-keepclassmembers class co.nimblehq.template.compose.data.requests.** { *; }
25+
-keepclassmembers class co.nimblehq.template.compose.data.responses.** { *; }

template-compose/app/src/main/java/co/nimblehq/template/compose/di/modules/MoshiModule.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package co.nimblehq.template.compose.di.modules
22

3-
import co.nimblehq.template.compose.data.service.providers.MoshiBuilderProvider
3+
import co.nimblehq.template.compose.data.services.providers.MoshiBuilderProvider
44
import com.squareup.moshi.Moshi
55
import dagger.Module
66
import dagger.Provides

template-compose/app/src/main/java/co/nimblehq/template/compose/di/modules/PreferencesModule.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import androidx.datastore.core.DataStore
55
import androidx.datastore.preferences.core.PreferenceDataStoreFactory
66
import androidx.datastore.preferences.core.Preferences
77
import androidx.datastore.preferences.preferencesDataStoreFile
8-
import co.nimblehq.template.compose.data.repository.AppPreferencesRepositoryImpl
9-
import co.nimblehq.template.compose.domain.repository.AppPreferencesRepository
8+
import co.nimblehq.template.compose.data.repositories.AppPreferencesRepositoryImpl
9+
import co.nimblehq.template.compose.domain.repositories.AppPreferencesRepository
1010
import dagger.*
1111
import dagger.hilt.InstallIn
1212
import dagger.hilt.android.qualifiers.ApplicationContext

template-compose/app/src/main/java/co/nimblehq/template/compose/di/modules/RepositoryModule.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package co.nimblehq.template.compose.di.modules
22

3-
import co.nimblehq.template.compose.data.repository.RepositoryImpl
4-
import co.nimblehq.template.compose.data.service.ApiService
5-
import co.nimblehq.template.compose.domain.repository.Repository
3+
import co.nimblehq.template.compose.data.repositories.RepositoryImpl
4+
import co.nimblehq.template.compose.data.services.ApiService
5+
import co.nimblehq.template.compose.domain.repositories.Repository
66
import dagger.Module
77
import dagger.Provides
88
import dagger.hilt.InstallIn

template-compose/app/src/main/java/co/nimblehq/template/compose/di/modules/RetrofitModule.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
package co.nimblehq.template.compose.di.modules
22

33
import co.nimblehq.template.compose.BuildConfig
4-
import co.nimblehq.template.compose.data.service.ApiService
5-
import co.nimblehq.template.compose.data.service.providers.ApiServiceProvider
6-
import co.nimblehq.template.compose.data.service.providers.ConverterFactoryProvider
7-
import co.nimblehq.template.compose.data.service.providers.RetrofitProvider
4+
import co.nimblehq.template.compose.data.services.ApiService
5+
import co.nimblehq.template.compose.data.services.providers.*
86
import com.squareup.moshi.Moshi
97
import dagger.Module
108
import dagger.Provides

template-compose/app/src/main/java/co/nimblehq/template/compose/di/modules/StorageModule.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package co.nimblehq.template.compose.di.modules
22

33
import android.content.Context
4-
import co.nimblehq.template.compose.data.storage.EncryptedSharedPreferences
4+
import co.nimblehq.template.compose.data.storages.EncryptedSharedPreferences
55
import dagger.Module
66
import dagger.Provides
77
import dagger.hilt.InstallIn

template-compose/app/src/main/java/co/nimblehq/template/compose/model/UiModel.kt

Lines changed: 0 additions & 9 deletions
This file was deleted.
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
package co.nimblehq.template.compose.ui.models
2+
3+
import co.nimblehq.template.compose.domain.models.Model
4+
5+
data class UiModel(
6+
val id: Int
7+
)
8+
9+
fun Model.toUiModel() = UiModel(id = id ?: -1)

template-compose/app/src/main/java/co/nimblehq/template/compose/ui/screens/home/HomeScreen.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ import androidx.hilt.navigation.compose.hiltViewModel
1313
import androidx.lifecycle.compose.collectAsStateWithLifecycle
1414
import co.nimblehq.template.compose.R
1515
import co.nimblehq.template.compose.extensions.collectAsEffect
16-
import co.nimblehq.template.compose.model.UiModel
1716
import co.nimblehq.template.compose.ui.AppDestination
17+
import co.nimblehq.template.compose.ui.models.UiModel
1818
import co.nimblehq.template.compose.ui.showToast
1919
import co.nimblehq.template.compose.ui.theme.AppTheme.dimensions
2020
import co.nimblehq.template.compose.ui.theme.ComposeTheme

template-compose/app/src/main/java/co/nimblehq/template/compose/ui/screens/home/HomeViewModel.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
package co.nimblehq.template.compose.ui.screens.home
22

33
import androidx.lifecycle.viewModelScope
4-
import co.nimblehq.template.compose.domain.usecase.UseCase
5-
import co.nimblehq.template.compose.model.UiModel
6-
import co.nimblehq.template.compose.model.toUiModel
4+
import co.nimblehq.template.compose.domain.usecases.UseCase
75
import co.nimblehq.template.compose.ui.base.BaseViewModel
6+
import co.nimblehq.template.compose.ui.models.UiModel
7+
import co.nimblehq.template.compose.ui.models.toUiModel
88
import co.nimblehq.template.compose.util.DispatchersProvider
99
import dagger.hilt.android.lifecycle.HiltViewModel
1010
import kotlinx.coroutines.flow.*

template-compose/app/src/test/java/co/nimblehq/template/compose/test/MockUtil.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package co.nimblehq.template.compose.test
22

3-
import co.nimblehq.template.compose.domain.model.Model
3+
import co.nimblehq.template.compose.domain.models.Model
44

55
object MockUtil {
66

template-compose/app/src/test/java/co/nimblehq/template/compose/ui/screens/home/HomeScreenTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import androidx.compose.ui.test.*
55
import androidx.compose.ui.test.junit4.*
66
import androidx.test.ext.junit.rules.ActivityScenarioRule
77
import co.nimblehq.template.compose.R
8-
import co.nimblehq.template.compose.domain.usecase.UseCase
8+
import co.nimblehq.template.compose.domain.usecases.UseCase
99
import co.nimblehq.template.compose.test.MockUtil
1010
import co.nimblehq.template.compose.ui.AppDestination
1111
import co.nimblehq.template.compose.ui.screens.BaseScreenTest

template-compose/app/src/test/java/co/nimblehq/template/compose/ui/screens/home/HomeViewModelTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
package co.nimblehq.template.compose.ui.screens.home
22

33
import app.cash.turbine.test
4-
import co.nimblehq.template.compose.domain.usecase.UseCase
5-
import co.nimblehq.template.compose.model.toUiModel
4+
import co.nimblehq.template.compose.domain.usecases.UseCase
65
import co.nimblehq.template.compose.test.CoroutineTestRule
76
import co.nimblehq.template.compose.test.MockUtil
7+
import co.nimblehq.template.compose.ui.models.toUiModel
88
import co.nimblehq.template.compose.util.DispatchersProvider
99
import io.kotest.matchers.shouldBe
1010
import io.mockk.every

template-compose/data/src/main/java/co/nimblehq/template/compose/data/extensions/ResponseMapping.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package co.nimblehq.template.compose.data.extensions
22

3-
import co.nimblehq.template.compose.data.response.ErrorResponse
4-
import co.nimblehq.template.compose.data.response.toModel
5-
import co.nimblehq.template.compose.data.service.providers.MoshiBuilderProvider
3+
import co.nimblehq.template.compose.data.responses.ErrorResponse
4+
import co.nimblehq.template.compose.data.responses.toModel
5+
import co.nimblehq.template.compose.data.services.providers.MoshiBuilderProvider
66
import co.nimblehq.template.compose.domain.exceptions.ApiException
77
import co.nimblehq.template.compose.domain.exceptions.NoConnectivityException
88
import com.squareup.moshi.JsonDataException
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
package co.nimblehq.template.compose.data.repository
1+
package co.nimblehq.template.compose.data.repositories
22

33
import android.util.Log
44
import androidx.datastore.core.DataStore
55
import androidx.datastore.preferences.core.*
6-
import co.nimblehq.template.compose.domain.repository.AppPreferencesRepository
6+
import co.nimblehq.template.compose.domain.repositories.AppPreferencesRepository
77
import kotlinx.coroutines.flow.*
88
import java.io.IOException
99
import javax.inject.Inject

template-compose/data/src/main/java/co/nimblehq/template/compose/data/repository/RepositoryImpl.kt renamed to template-compose/data/src/main/java/co/nimblehq/template/compose/data/repositories/RepositoryImpl.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
package co.nimblehq.template.compose.data.repository
1+
package co.nimblehq.template.compose.data.repositories
22

33
import co.nimblehq.template.compose.data.extensions.flowTransform
4-
import co.nimblehq.template.compose.data.response.toModels
5-
import co.nimblehq.template.compose.data.service.ApiService
6-
import co.nimblehq.template.compose.domain.model.Model
7-
import co.nimblehq.template.compose.domain.repository.Repository
4+
import co.nimblehq.template.compose.data.responses.toModels
5+
import co.nimblehq.template.compose.data.services.ApiService
6+
import co.nimblehq.template.compose.domain.models.Model
7+
import co.nimblehq.template.compose.domain.repositories.Repository
88
import kotlinx.coroutines.flow.Flow
99

1010
class RepositoryImpl constructor(

template-compose/data/src/main/java/co/nimblehq/template/compose/data/requests/.keep

Whitespace-only changes.

template-compose/data/src/main/java/co/nimblehq/template/compose/data/response/ErrorResponse.kt renamed to template-compose/data/src/main/java/co/nimblehq/template/compose/data/responses/ErrorResponse.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
package co.nimblehq.template.compose.data.response
1+
package co.nimblehq.template.compose.data.responses
22

3-
import co.nimblehq.template.compose.domain.model.Error
3+
import co.nimblehq.template.compose.domain.models.Error
44
import com.squareup.moshi.Json
55

66
data class ErrorResponse(

template-compose/data/src/main/java/co/nimblehq/template/compose/data/response/Response.kt renamed to template-compose/data/src/main/java/co/nimblehq/template/compose/data/responses/Response.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
package co.nimblehq.template.compose.data.response
1+
package co.nimblehq.template.compose.data.responses
22

3-
import co.nimblehq.template.compose.domain.model.Model
3+
import co.nimblehq.template.compose.domain.models.Model
44
import com.squareup.moshi.Json
55

66
data class Response(

template-compose/data/src/main/java/co/nimblehq/template/compose/data/service/ApiService.kt renamed to template-compose/data/src/main/java/co/nimblehq/template/compose/data/services/ApiService.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
package co.nimblehq.template.compose.data.service
1+
package co.nimblehq.template.compose.data.services
22

3-
import co.nimblehq.template.compose.data.response.Response
3+
import co.nimblehq.template.compose.data.responses.Response
44
import retrofit2.http.GET
55

66
interface ApiService {
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
package co.nimblehq.template.compose.data.service.providers
1+
package co.nimblehq.template.compose.data.services.providers
22

3-
import co.nimblehq.template.compose.data.service.ApiService
3+
import co.nimblehq.template.compose.data.services.ApiService
44
import retrofit2.Retrofit
55

66
object ApiServiceProvider {
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package co.nimblehq.template.compose.data.service.providers
1+
package co.nimblehq.template.compose.data.services.providers
22

33
import com.squareup.moshi.Moshi
44
import retrofit2.Converter
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
package co.nimblehq.template.compose.data.service.providers
1+
package co.nimblehq.template.compose.data.services.providers
22

33
import com.squareup.moshi.Moshi
44
import com.squareup.moshi.adapters.Rfc3339DateJsonAdapter
55
import com.squareup.moshi.kotlin.reflect.KotlinJsonAdapterFactory
6-
import java.util.*
6+
import java.util.Date
77

88
object MoshiBuilderProvider {
99

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package co.nimblehq.template.compose.data.service.providers
1+
package co.nimblehq.template.compose.data.services.providers
22

33
import okhttp3.OkHttpClient
44
import retrofit2.Converter
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package co.nimblehq.template.compose.data.storage
1+
package co.nimblehq.template.compose.data.storages
22

33
import android.content.SharedPreferences
44

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package co.nimblehq.template.compose.data.storage
1+
package co.nimblehq.template.compose.data.storages
22

33
import android.content.Context
44
import androidx.security.crypto.EncryptedSharedPreferences
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package co.nimblehq.template.compose.data.storage
1+
package co.nimblehq.template.compose.data.storages
22

33
import android.content.SharedPreferences
44

template-compose/data/src/test/java/co/nimblehq/template/compose/data/extensions/ResponseMappingTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
package co.nimblehq.template.compose.data.extensions
22

3-
import co.nimblehq.template.compose.data.response.toModel
3+
import co.nimblehq.template.compose.data.responses.toModel
44
import co.nimblehq.template.compose.data.test.MockUtil
55
import co.nimblehq.template.compose.domain.exceptions.ApiException
66
import co.nimblehq.template.compose.domain.exceptions.NoConnectivityException
7-
import co.nimblehq.template.compose.domain.model.Model
7+
import co.nimblehq.template.compose.domain.models.Model
88
import io.kotest.matchers.shouldBe
99
import kotlinx.coroutines.ExperimentalCoroutinesApi
1010
import kotlinx.coroutines.flow.catch
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
package co.nimblehq.template.compose.data.repository
1+
package co.nimblehq.template.compose.data.repositories
22

33
import android.content.Context
44
import androidx.datastore.core.DataStore
55
import androidx.datastore.preferences.core.*
66
import androidx.datastore.preferences.preferencesDataStoreFile
77
import androidx.test.core.app.ApplicationProvider
88
import app.cash.turbine.test
9-
import co.nimblehq.template.compose.domain.repository.AppPreferencesRepository
9+
import co.nimblehq.template.compose.domain.repositories.AppPreferencesRepository
1010
import io.kotest.matchers.shouldBe
1111
import io.mockk.every
1212
import io.mockk.mockk

template-compose/data/src/test/java/co/nimblehq/template/compose/data/repository/RepositoryTest.kt renamed to template-compose/data/src/test/java/co/nimblehq/template/compose/data/repositories/RepositoryTest.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
package co.nimblehq.template.compose.data.repository
1+
package co.nimblehq.template.compose.data.repositories
22

3-
import co.nimblehq.template.compose.data.response.toModels
4-
import co.nimblehq.template.compose.data.service.ApiService
3+
import co.nimblehq.template.compose.data.responses.toModels
4+
import co.nimblehq.template.compose.data.services.ApiService
55
import co.nimblehq.template.compose.data.test.MockUtil
6-
import co.nimblehq.template.compose.domain.repository.Repository
6+
import co.nimblehq.template.compose.domain.repositories.Repository
77
import io.kotest.matchers.shouldBe
88
import io.mockk.coEvery
99
import io.mockk.mockk

template-compose/data/src/test/java/co/nimblehq/template/compose/data/test/MockUtil.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package co.nimblehq.template.compose.data.test
22

3-
import co.nimblehq.template.compose.data.response.ErrorResponse
3+
import co.nimblehq.template.compose.data.responses.ErrorResponse
44
import io.mockk.every
55
import io.mockk.mockk
66
import okhttp3.ResponseBody
@@ -31,6 +31,6 @@ object MockUtil {
3131
)
3232

3333
val responses = listOf(
34-
co.nimblehq.template.compose.data.response.Response(id = 1)
34+
co.nimblehq.template.compose.data.responses.Response(id = 1)
3535
)
3636
}

template-compose/domain/src/main/java/co/nimblehq/template/compose/domain/exceptions/Exceptions.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package co.nimblehq.template.compose.domain.exceptions
22

3-
import co.nimblehq.template.compose.domain.model.Error
3+
import co.nimblehq.template.compose.domain.models.Error
44

55
object NoConnectivityException : RuntimeException()
66

template-compose/domain/src/main/java/co/nimblehq/template/compose/domain/model/Error.kt

Lines changed: 0 additions & 5 deletions
This file was deleted.

template-compose/domain/src/main/java/co/nimblehq/template/compose/domain/model/Model.kt

Lines changed: 0 additions & 5 deletions
This file was deleted.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
package co.nimblehq.template.compose.domain.models
2+
3+
data class Error(
4+
val message: String
5+
)
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
package co.nimblehq.template.compose.domain.models
2+
3+
data class Model(
4+
val id: Int?
5+
)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package co.nimblehq.template.compose.domain.repository
1+
package co.nimblehq.template.compose.domain.repositories
22

33
import kotlinx.coroutines.flow.Flow
44

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
package co.nimblehq.template.compose.domain.repositories
2+
3+
import co.nimblehq.template.compose.domain.models.Model
4+
import kotlinx.coroutines.flow.Flow
5+
6+
interface Repository {
7+
8+
fun getModels(): Flow<List<Model>>
9+
}

template-compose/domain/src/main/java/co/nimblehq/template/compose/domain/repository/Repository.kt

Lines changed: 0 additions & 9 deletions
This file was deleted.

template-compose/domain/src/main/java/co/nimblehq/template/compose/domain/usecase/UseCase.kt renamed to template-compose/domain/src/main/java/co/nimblehq/template/compose/domain/usecases/UseCase.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package co.nimblehq.template.compose.domain.usecase
1+
package co.nimblehq.template.compose.domain.usecases
22

3-
import co.nimblehq.template.compose.domain.model.Model
4-
import co.nimblehq.template.compose.domain.repository.Repository
3+
import co.nimblehq.template.compose.domain.models.Model
4+
import co.nimblehq.template.compose.domain.repositories.Repository
55
import kotlinx.coroutines.flow.Flow
66
import javax.inject.Inject
77

template-compose/domain/src/test/java/co/nimblehq/template/compose/domain/test/MockUtil.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package co.nimblehq.template.compose.domain.test
22

3-
import co.nimblehq.template.compose.domain.model.Model
3+
import co.nimblehq.template.compose.domain.models.Model
44

55
object MockUtil {
66

template-compose/domain/src/test/java/co/nimblehq/template/compose/domain/usecase/UseCaseTest.kt renamed to template-compose/domain/src/test/java/co/nimblehq/template/compose/domain/usecases/UseCaseTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
package co.nimblehq.template.compose.domain.usecase
1+
package co.nimblehq.template.compose.domain.usecases
22

3-
import co.nimblehq.template.compose.domain.repository.Repository
3+
import co.nimblehq.template.compose.domain.repositories.Repository
44
import co.nimblehq.template.compose.domain.test.MockUtil
55
import io.kotest.matchers.shouldBe
66
import io.mockk.every

0 commit comments

Comments
 (0)