Skip to content

Commit 2232710

Browse files
lydiasamalydiasama
authored
Merge pull request #125 from nimblehq/release/3.1.0
[Release] 3.1.0
2 parents 9dbd69e + dfd98b9 commit 2232710

File tree

9 files changed

+86
-10
lines changed

9 files changed

+86
-10
lines changed

‎.github/ISSUE_TEMPLATE/story_template.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
---
2+
name: "Story"
3+
about: "Open a feature story"
4+
title: "[Type] As a user, I can "
5+
labels: "type : feature"
6+
---
7+
8+
## Why
9+
10+
Describe the idea of the user story as in what the motive of the user story is.
11+
12+
## Acceptance Criteria
13+
14+
List down how the user story will be tested and what criteria are necessary for the user story to be accepted.
15+
16+
## Design
17+
18+
(Optional) Add design screenshots or Figma links for UI/UX-related stories.
19+
20+
## Resources
21+
22+
(Optional) Add useful resources such as links to documentation, implementation ideas, or best practices.

‎.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,17 @@
1+
Note: for a release PR, append this parameter `?template=release_template.md` to the current URL to apply the release PR template, e.g. `{Github PR URL}?template=release_template.md`
2+
3+
--
4+
15
https://github.com/nimblehq/android-templates/issues/??
26

37
## What happened 👀
48

5-
Describe the big picture of your changes here to communicate to the team why we should accept this pull request.
6-
9+
Describe the big picture of your changes here to communicate to the team why we should accept this pull request.
10+
711
## Insight 📝
812

913
Describe in details how to test the changes, which solution you tried but did not go with, referenced documentation is welcome as well.
10-
14+
1115
## Proof Of Work 📹
1216

1317
Show us the implementation: screenshots, gif, etc.

‎.github/PULL_REQUEST_TEMPLATE/RELEASE_TEMPLATE.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
Link to the milestone on Github e.g. https://github.com/nimblehq/git-templates/milestone/41?closed=1
2+
or
3+
Link to the project management tool for the release
4+
5+
## Features
6+
7+
Provide the ID and title of the issue in the section for each type (feature, chore and bug). The link is optional.
8+
9+
- [ch1234] As a user, I can log in
10+
or
11+
- [[ch1234](https://github.com/nimblehq/git-templates/issues/1234)] As a user, I can log in
12+
13+
## Chores
14+
- Same structure as in ## Feature
15+
16+
## Bugs
17+
- Same structure as in ## Feature

‎CoroutineTemplate/app/src/main/AndroidManifest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
android:allowBackup="true"
1010
android:icon="@mipmap/ic_launcher"
1111
android:label="@string/app_name"
12+
android:networkSecurityConfig="@xml/network_security_config"
1213
android:roundIcon="@mipmap/ic_launcher_round"
1314
android:supportsRtl="true"
1415
android:theme="@style/AppTheme">

‎CoroutineTemplate/app/src/main/res/xml/network_security_config.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
<network-security-config />

‎CoroutineTemplate/app/src/staging/res/xml/network_security_config.xml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
<network-security-config>
2+
<debug-overrides>
3+
<trust-anchors>
4+
<!-- Only trust user added CAs while app is debuggable -->
5+
<certificates src="user" />
6+
<certificates src="system" />
7+
</trust-anchors>
8+
</debug-overrides>
9+
10+
<domain-config>
11+
<!-- Enter your base URL here -->
12+
<domain includeSubdomains="true">www.jsonplaceholder.typicode.com</domain>
13+
<trust-anchors>
14+
<certificates src="user" />
15+
<certificates src="system" />
16+
</trust-anchors>
17+
</domain-config>
18+
</network-security-config>

‎RxJavaTemplate/app/src/main/res/xml/network_security_config.xml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1 @@
1-
<?xml version="1.0" encoding="utf-8"?>
2-
<network-security-config>
3-
<domain-config cleartextTrafficPermitted="true">
4-
<domain includeSubdomains="true">monkeyuser.com</domain>
5-
</domain-config>
6-
</network-security-config>
1+
<network-security-config />

‎RxJavaTemplate/app/src/staging/res/xml/network_security_config.xml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
<network-security-config>
2+
<debug-overrides>
3+
<trust-anchors>
4+
<!-- Only trust user added CAs while app is debuggable -->
5+
<certificates src="user" />
6+
<certificates src="system" />
7+
</trust-anchors>
8+
</debug-overrides>
9+
10+
<domain-config>
11+
<!-- Enter your base URL here -->
12+
<domain includeSubdomains="true">www.reddit.com</domain>
13+
<trust-anchors>
14+
<certificates src="user" />
15+
<certificates src="system" />
16+
</trust-anchors>
17+
</domain-config>
18+
</network-security-config>

‎RxJavaTemplate/data/src/production/java/co/nimblehq/rxjava/data/service/common/secrets/ApiEndpointUrlImpl.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ package co.nimblehq.rxjava.data.service.common.secrets
22

33
class ApiEndpointUrlImpl : ApiEndpointUrl {
44
override val value: String
5-
get() = TODO("Not implement yet, please modify this for your Production usage")
5+
get() = "https://www.reddit.com/"
66
}

0 commit comments

Comments
 (0)